Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] LHN - "No activity yet message showed in LHN rooms with conv history after coming back online #30392

Closed
1 of 6 tasks
lanitochka17 opened this issue Oct 25, 2023 · 55 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@lanitochka17
Copy link

lanitochka17 commented Oct 25, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.3.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Create a new applause.expensifail account on staging.new.expensify.com
  2. Disable the internet connection in the device
  3. Tap on the green plus button (FAB) and create a new Workspace
  4. Navigate to LHN
  5. Enter any of the new rooms and send some messages
  6. Go back online

Expected Result:

Last send message into workspace rooms should be visible in LHN when come back online

Actual Result:

"No activity yet" message showed in LHN under workspace rooms

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Bug6250835_1698264593455.az_recorder_20231025_200808.mp4
MacOS: Chrome / Safari
MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~014dee0189b20922e7
  • Upwork Job ID: 1717286481120063488
  • Last Price Increase: 2023-11-01
Issue OwnerCurrent Issue Owner: @youssef-lr
@lanitochka17 lanitochka17 added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 25, 2023
@melvin-bot melvin-bot bot changed the title LHN - "No activity yet message showed in LHN rooms with conv history after coming back online [$500] LHN - "No activity yet message showed in LHN rooms with conv history after coming back online Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~014dee0189b20922e7

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

@bernhardoj
Copy link
Contributor

Pretty sure this is a regression from #29568 where we show the "No activity yet" if the report's actions/messages are not loaded yet (even though the report object has a last message text value lastMessageTextFromReport).

image

This affects a lot of reports (mainly chat rooms). You will see many room chats' last message text shown as "No activity yet" after re-login.

@alexpensify
Copy link
Contributor

@s77rt - do you agree with this feedback from @bernhardoj?

@s77rt
Copy link
Contributor

s77rt commented Oct 26, 2023

@alexpensify Yes! That makes sense to me. I have asked if that change was intended here. cc @youssef-lr

@youssef-lr
Copy link
Contributor

Yeah this looks like a regression from my PR. I added this change for the case of split bills that contain a receipt, the other participant receives a last message text from the backend which says "split $0.0" when the receipt is still being scanned, even though this last message is actually a whisper to the creator of the split. So I think proper way is to get it fixed in the backend and we can revert my change at line 306.

@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@s77rt
Copy link
Contributor

s77rt commented Oct 30, 2023

Should this be internal in that case?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 30, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@s77rt
Copy link
Contributor

s77rt commented Nov 1, 2023

Not overdue. Maybe internal? ^

@melvin-bot melvin-bot bot removed the Overdue label Nov 1, 2023
@alexpensify
Copy link
Contributor

@youssef-lr can you check if we should take this internal and edit the tags here? Thanks!

@youssef-lr youssef-lr self-assigned this Nov 1, 2023
@youssef-lr youssef-lr added Internal Requires API changes or must be handled by Expensify staff and removed External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors labels Nov 1, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

@youssef-lr
Copy link
Contributor

Going to take this internal and assign it to myself

@alexpensify
Copy link
Contributor

Sounds good @youssef-lr, I'm going to assign you the primary role in this GH.

@youssef-lr
Copy link
Contributor

Same.

@melvin-bot melvin-bot bot removed the Overdue label Mar 20, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@youssef-lr
Copy link
Contributor

No update yet

@melvin-bot melvin-bot bot removed the Overdue label Apr 3, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 11, 2024
@youssef-lr
Copy link
Contributor

Same.

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 29, 2024
@youssef-lr
Copy link
Contributor

No update yet.

@melvin-bot melvin-bot bot removed the Overdue label May 1, 2024
@melvin-bot melvin-bot bot added the Overdue label May 9, 2024
@youssef-lr
Copy link
Contributor

No update yet, still a low priority.

@melvin-bot melvin-bot bot removed the Overdue label May 9, 2024
@alexpensify
Copy link
Contributor

Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.

If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks!

@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@youssef-lr
Copy link
Contributor

No update yet.

@melvin-bot melvin-bot bot removed the Overdue label May 21, 2024
@melvin-bot melvin-bot bot added the Overdue label May 29, 2024
@youssef-lr
Copy link
Contributor

Same.

@melvin-bot melvin-bot bot removed the Overdue label Jun 5, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 13, 2024
@youssef-lr
Copy link
Contributor

No update, probably worth retesting this it might have been resolved.

@melvin-bot melvin-bot bot removed the Overdue label Jun 19, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 28, 2024
@youssef-lr
Copy link
Contributor

Couldn't reproduce this anymore, closing!

@melvin-bot melvin-bot bot removed the Overdue label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Engineering Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
No open projects
Archived in project
Development

No branches or pull requests

5 participants