-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$500] LHN - "No activity yet message showed in LHN rooms with conv history after coming back online #30392
Comments
Job added to Upwork: https://www.upwork.com/jobs/~014dee0189b20922e7 |
Triggered auto assignment to @alexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
Pretty sure this is a regression from #29568 where we show the "No activity yet" if the report's actions/messages are not loaded yet (even though the report object has a last message text value This affects a lot of reports (mainly chat rooms). You will see many room chats' last message text shown as "No activity yet" after re-login. |
@s77rt - do you agree with this feedback from @bernhardoj? |
@alexpensify Yes! That makes sense to me. I have asked if that change was intended here. cc @youssef-lr |
Yeah this looks like a regression from my PR. I added this change for the case of split bills that contain a receipt, the other participant receives a last message text from the backend which says "split $0.0" when the receipt is still being scanned, even though this last message is actually a whisper to the creator of the split. So I think proper way is to get it fixed in the backend and we can revert my change at line 306. |
Should this be internal in that case? |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Not overdue. Maybe internal? ^ |
@youssef-lr can you check if we should take this internal and edit the tags here? Thanks! |
Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new. |
Going to take this internal and assign it to myself |
Sounds good @youssef-lr, I'm going to assign you the primary role in this GH. |
Same. |
No update yet |
Same. |
No update yet. |
No update yet, still a low priority. |
Heads up, I will be offline until Tuesday, May 28, 2024, and will not actively watch over this GitHub during that period.If anything urgent is needed here, please ask for help in the #expensify-open-source Slack Room-- thanks! |
No update yet. |
Same. |
No update, probably worth retesting this it might have been resolved. |
Couldn't reproduce this anymore, closing! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.91-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Last send message into workspace rooms should be visible in LHN when come back online
Actual Result:
"No activity yet" message showed in LHN under workspace rooms
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
Bug6250835_1698264593455.az_recorder_20231025_200808.mp4
MacOS: Chrome / Safari
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @youssef-lrThe text was updated successfully, but these errors were encountered: