[$500] Scan - __ fake __ is displayed as owner of the system generated message for failed scanning

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.88-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #27494

Action Performed:

1. Go to staging.new.expensify.com
2. Create a Scan request using a receipt with no merchant
3. Wait for it to fail
4. When it fails, open the IOU details page

Expected Result:

The system generated message for 'Receipt scanning failed' should be assigned with an appropriate user

Actual Result:

__ fake __ is displayed as the owner of the system generated message for 'Receipt scanning failed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6245666_1697907464369.bandicam_2023-10-21_22-56-55-613.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01fb00b2dc10f94a59
• Upwork Job ID: 1715843159501512704
• Last Price Increase: 2023-10-28

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01fb00b2dc10f94a59

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[wlegolas]

Hello!

I was doing my investigation to generate my proposal but in my RCA I understood that the problem is more related to the backend than the frontend, for this reason, I didn't create a proposal, but to help resolve this issue I'll put below the result related to my RCA

Results from my RCA

When creating a Scan request using a receipt with no merchant, and occurs an error, the backend returns the report action with the "0" value in the actorAccountID. And this value is important to extract the actor information in the personalDetailsList.

Inside the ReportActionItemSingle component, is extracted the displayName from the personal list using the actorAccountID from the action report (in this case the value is "0"):

App/src/pages/home/report/ReportActionItemSingle.js

Lines 90 to 92 in dcb698f

	function ReportActionItemSingle(props) {
	const actorAccountID = props.action.actionName === CONST.REPORT.ACTIONS.TYPE.REPORTPREVIEW && props.iouReport ? props.iouReport.managerID : props.action.actorAccountID;
	let {displayName} = props.personalDetailsList[actorAccountID] || {};

There is the variable personArray that will have the array with the person's information, there is a condition to generate the person's information, if the variable displayName has a value, will create an array with the displayName as the text, otherwise, will be used the information person from the action (that is this the issue case)

App/src/pages/home/report/ReportActionItemSingle.js

Lines 136 to 143 in dcb698f

	const personArray = displayName
	? [
	{
	type: 'TEXT',
	text: displayName,
	},
	]
	: props.action.person;

In this case, the ReportActionItemSingle component is using the person from the action, and if you see in the image above, the "person" property inside the action has the text "fake".

I hope this helps.

[wlegolas]

Hello @lanitochka17, could you share a receipt with a merchant, please?

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Scan - __ fake __ is displayed as owner of the system generated message for failed scanning

What is the root cause of that problem?

After scanning receipt failed, we get the report action below:

As we can see the actorAccountID is 0 and person is fake

What changes do you think we should make in order to solve the problem?

It's because of this message does not belong to any users so the actorAccountID is 0

Option 1: We should define new actionName for this message, something like Scanning Error, and just show this message as the simple text. (The same way we did with Rename)

Option 2: We can check if the actionName is 0 so we should not show the avatar and displayName

Result

[laurenreidexpensify]

@Ollyws what do you think of the proposals above?

[Ollyws]

I think some back-end changes will probably be required here so this should possibly be internal.

[tienifr]

@Ollyws Don't you think we should change on FE side?. IMO we should handle both

[Ollyws]

Yes I imagine it would involve a combination, adding a new action name would have to be done on the BE side too.
Either way it would be good to get the input of an internal engineer.

[melvin-bot]

Triggered auto assignment to @neil-marcellini (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[mallenexpensify]

Posted the below in an internal room

Are undefined & and _fake_ correlated-enough that, for the issue above, we want to do something to inc or consider undefined & ? Right now it's not mentioned in the GH, I'm going to ask there too and link to here.

@neil-marcellini I added the engineering label for bonus 👀, in case the two are related and we're able to expedite getting this fixed, check the link above for the discussion, which is more about undefined & than _fake_

[neil-marcellini]

@Gonals may I re-assign this to you? I believe you recently implemented this.

[mallenexpensify]

I co-assigned, only to ensure @Gonals sees this. One of y'all, please unassign the other! Thx

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[laurenreidexpensify]

@neil-marcellini @Gonals can you review and confirm above thanks?

[melvin-bot]

Current assignee @Ollyws is eligible for the Internal assigner, not assigning anyone new.

[Gonals]

I am fairly sure this is caused by us using an invalid account. AKA: [email protected] (which should be the account posting this) does not exist or is in a weird state. Checking from supportal, it seems it was originally created in a closed state, so my bet is that Account::getID is not getting it correctly.

In dev, passing a valid account there fixes the problem, so I don't think we need any frontend changes.

Auth PR incoming

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Gonals]

This should be fixed already