-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-31] Address - 'Hmm it's not here' page shows up when selecting a country #30128
Comments
Triggered auto assignment to @JmillsExpensify ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @luacmartins ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.Address - 'Hmm it's not here' page shows up when selecting a country What is the root cause of that problem?After select country we backTo using
the issue here is the URL is not correct, so the route.params.backTo is return undifinedthe url has 2 "?" ?country=US?backTo= http://localhost:8082/settings/profile/personal-details/address/country?country=US?backTo=%2Fsettings%2Fprofile%2Fpersonal-details%2Faddress this because Lines 14 to 16 in 6031f3e
What changes do you think we should make in order to solve the problem?We need to change function getBackToParam(backTo?: string, isFirstParam: boolean = true): string {
return backTo ? `${isFirstParam ? "?" : "&"}backTo=${encodeURIComponent(backTo)}` : '';
} What alternative solutions did you explore? (Optional)or replace function getUrlWithBackToParam(url: string, backTo?: string): string {
const backToParam = backTo ? `${url.includes("?") ? "&" : "?"}backTo=${encodeURIComponent(backTo)}` : '';
return url + backToParam;
}
// use it like this
// getRoute: (accountID: string | number, backTo?: string) => `a/${accountID}${getBackToParam(backTo)}`
getRoute: (accountID: string | number, backTo?: string) => getUrlWithBackToParam(`a/${accountID}`) |
Hmm I tried the revert of that PR but still running into a different problem when trying the reproduction steps Uncaught Error: allCountries.a was not found in the default language |
Ah nevermind, looks like it is fixed after NPM install - going with a straight revert here |
I think @ahmedGaber93's solution with |
@JmillsExpensify What I have usually applied was the 25% rule so that would be $125 to @ahmedGaber93 |
Fixed in staging |
@luacmartins Quick check on the regression test. Do you think we need one for this case? |
No need for a regression test. Applause caught this during it already. |
Just missing payment here |
Same |
@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
1 similar comment
@JmillsExpensify, @luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Ok great, circling back for payment then. |
Just missing payment |
@JmillsExpensify, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@ahmedGaber93 Do you mind confirming that you haven't been paid for this issue? I'm unable to find a linked Upwork job, so I just want to be sure before creating another job. |
@JmillsExpensify no, I haven't been paid for this issue. |
Thanks I'll create an Upwork job now. |
Mind applying here: https://www.upwork.com/jobs/~0172d8e78897a88014 |
@JmillsExpensify Applied. |
Offer sent! Thank you |
Offer paid via Upwork. Thanks everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.88-3
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
Country is selected successfully
Actual Result:
'Hmm it's not here' page shows up
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Bug6245644_1697905786399.bandicam_2023-10-21_20-14-31-107.mp4
MacOS: Desktop
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: