Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PENDING BUG REPORT PAYOUT][$500] Dev: Can't request money using Distance #30022

Closed
6 tasks done
kbecciv opened this issue Oct 19, 2023 · 26 comments
Closed
6 tasks done
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kbecciv
Copy link

kbecciv commented Oct 19, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: Dev 1.3.87.0
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ayazhussain79
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697736215925649

Action Performed:

  1. Click on the "+" button or go to the expense room.
  2. Navigate to Request money > Distance.
  3. Select the Start and Finish points and send the request.
  4. Go to the distance request detail page.
  5. Attempt to send it.
  6. Observe that the send button is disabled without any error message

Expected Result:

The Distance "Request" button should not be disabled without showing an error message

Actual Result:

The Distance "Request" button is disabled without any error message

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Android: Native
Screen.Recording.2023-10-19.at.10.52.26.PM.mov
Android: mWeb Chrome
Screen.Recording.2023-10-19.at.10.52.26.PM.mov
iOS: Native
Screen.Recording.2023-10-19.at.10.26.32.PM.mov
iOS: mWeb Safari
Screen.Recording.2023-10-19.at.10.26.32.PM.mov
MacOS: Chrome / Safari
2023-10-19.22-23-56.mp4
MacOS: Desktop
Screen.Recording.2023-10-19.at.11.20.48.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~013fce63774ec87caa
  • Upwork Job ID: 1715097232167661568
  • Last Price Increase: 2023-10-19
@kbecciv kbecciv added External Added to denote the issue can be worked on by a contributor Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@melvin-bot melvin-bot bot changed the title Dev: When requesting Distance money, the amount is displaying as 0 [$500] Dev: When requesting Distance money, the amount is displaying as 0 Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Job added to Upwork: https://www.upwork.com/jobs/~013fce63774ec87caa

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @akinwale (External)

@isabelastisser
Copy link
Contributor

I'm heading ooo and need to reassign this.

@isabelastisser isabelastisser removed their assignment Oct 19, 2023
@isabelastisser isabelastisser added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 19, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@incregeni
Copy link

I am interested in

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

📣 @incregeni! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Make sure you've read and understood the contributing guidelines.
  2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@Izurii
Copy link

Izurii commented Oct 19, 2023

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0151fd6281bfe00ecc

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

1 similar comment
@melvin-bot
Copy link

melvin-bot bot commented Oct 19, 2023

⚠️ Missing/invalid email or upwork profile link. Please make sure you add both your Expensify email and Upwork profile link in the format specified.

@pecanoro pecanoro added the DeployBlockerCash This issue or pull request should block deployment label Oct 20, 2023
@pecanoro
Copy link
Contributor

Adding a deploy blocker to this issue since this one is pretty bad as it broke the whole distance functionality, some recent PR must have broken it

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Oct 20, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

Triggered auto assignment to @marcaaron (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@pecanoro pecanoro changed the title [$500] Dev: When requesting Distance money, the amount is displaying as 0 [$500] Dev: Can't request money using Distance Oct 20, 2023
@thienlnam
Copy link
Contributor

This should be resolved now,

This was the PR that caused the regression, we ended up reverting it in this PR to solve a different regression

@thienlnam
Copy link
Contributor

Going to run through the steps just to verify very quickly

@thienlnam
Copy link
Contributor

Yup verified 👍 Leaving this open for bug report though

@thienlnam thienlnam added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor Engineering Hourly KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Oct 20, 2023
@thienlnam thienlnam changed the title [$500] Dev: Can't request money using Distance [PENDING BUG REPORT PAYOUT][$500] Dev: Can't request money using Distance Oct 20, 2023
@ChrissieBosman
Copy link

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~0195025a8dee38e619

@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@garrettmknight, @akinwale, @marcaaron Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@garrettmknight
Copy link
Contributor

@ayazhussain79 offer out to you for the reporter role - accept and I'll pay!

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@ayazhussain79
Copy link
Contributor

@garrettmknight Offer accepted, Thank you

@garrettmknight
Copy link
Contributor

Paid, closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests