-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-12-08] [$1000] IOU - Tapping download on manual money request receipt app crashes #29788
Comments
Triggered auto assignment to @isabelastisser ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @marcochavezf ( |
Posted in wave4 in case someone has more context about the issue |
ProposalPlease re-state the problem that we are trying to solve in this issue.Tapping download on manual money request receipt app crash What is the root cause of that problem?
local file referring to the file:/ so isLocalFile is false so its pointing the HTTP URL so that its crashing
this plugin https://www.npmjs.com/package/react-native-document-picker return this format only in [{"fileCopyUri": "file:/data/user/0/com.expensify.chat.dev/cache/676d92f0-d911-4f36-b514-09171f701681/w_1616fc868aa6834d5082e20f9b40b9a667511f8f-2023-10-17%2016_18_46.350.jpg", "name": "w_1616fc868aa6834d5082e20f9b40b9a667511f8f-2023-10-17 16_18_46.350.jpg", "size": 932381, "type": "image/jpeg", "uri": "content://com.android.providers.media.documents/document/image%3A1000045261"}] What changes do you think we should make in order to solve the problem?we can check with or here
we should change file:/ -> file:// in fileCopyUri
we need check |
@pradeepmdk do you see any recent changes/pull request that could have introduced this crash? All the code you linked to doesn't seem to have changed in a few months, so I'm curious why we're only seeing this now. Or maybe it's because we just started using Anyway, thanks for the proposal, I'll run some tests to see if it fixes the crash. |
For deploy blocker issues, offending PR should be pointed out in the root cause of proposal. |
I just have updated the app from playstore and issue is also there (v1.3.84-10)means this is not a deploy blocker :) |
@lanitochka17 can you please confirm that this is not reproducible on production? |
ProposalPlease re-state the problem that we are trying to solve in this issue.IOU - Tapping download on manual money request receipt app crashes What is the root cause of that problem?This is an issue with upstream. Maybe due to slow-network or some other reason the receipt image is pointed to local which causing the issue.
But the real RCA is from the upstream. As per the documentation when we pass https://docs.oracle.com/javase%2F7%2Fdocs%2Fapi%2F%2F/java/io/File.html#toURI() react-native-documents/document-picker#527 What changes do you think we should make in order to solve the problem?We can upgrade the package https://developer.android.com/reference/android/net/Uri#fromFile(java.io.File) What alternative solutions did you explore? (Optional)NA |
I think the issue exists before but we were not able to catch this because we added scan/preview/ menu options feature recently and also I think because of the file-size or some other reason the API request hasn't been completed fully by the time when we open modal so thus it is pointing the image to local path which let the team to catch this issue. |
Job added to Upwork: https://www.upwork.com/jobs/~01728d6678a4828e28 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh ( |
Current assignee @situchan is eligible for the Internal assigner, not assigning anyone new. |
bump @situchan ^^ |
@dylanexpensify @situchan Asked for a review in the PR, I updated it only yesterday. He might check it today. |
@situchan what's the update here? |
PR is in review |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.6-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-12-08. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue: |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
Payment upcoming! |
@situchan please complete the checklist above. Thanks! |
The bug always existed after we enable local file download. Was issue in upstream. |
The payments were made in Upwork. All set! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.3.85-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
Action Performed:
Expected Result:
When user taps download in receipt page, receipt must be downloaded
Actual Result:
When user taps download in receipt page, app crashes
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Android: Native
Bug6240242_1697536635359.steps_crash.1.mp4
logs 3.txt
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: