[$500] Edit private note form doesn't submit by enter key

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open a report that has the private note option
2. Click on the header > Private notes
3. Select a private note to open the edit page
4. Edit the private note and press enter key

Expected Result:

The private note should be saved and go back to the previous page

Actual Result:

The input adds a new line

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.77-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-10-04.at.15.07.46.mov

Screen.Recording.2023-10-04.at.15.08.32.mov

Recording.470.mp4

Expensify/Expensify Issue URL:
Issue reported by: @dukenv0307
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696405348401729

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01114e9ac4dbe61472
• Upwork Job ID: 1709667574583115776
• Last Price Increase: 2023-10-11

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01114e9ac4dbe61472

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[m-natarajan]

Proposal by @dukenv0307

Please re-state the problem that we are trying to solve in this issue.

Edit private note form doesn't submit by pressing enter key

What is the root cause of that problem?

We don't add submitOnEnter prop to allow the submission of the form by pressing the enter key

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 142 in 447d87e

<TextInput

We should add submitOnEnter prop to the text input to make the form can be submitted by pressing enter key

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 142 in 447d87e

<TextInput

What alternative solutions did you explore? (Optional)

NA

Result

Screencast.from.04-10-2023.15.19.04.webm

[alitoshmatov]

Looks like it is intended behavior. Since notes might be multiline

[ayazalavi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enter button is not submitting privates notes form.

What is the root cause of that problem?

Root cause of the problem is we have policy about when form should be submitted on pressing enter and when we should add a new line on pressing shift+enter. There is prop for multiline inputs that allow us to handle form like this

App/src/components/TextInput/baseTextInputPropTypes.js

Line 89 in 6d86d5a

submitOnEnter: PropTypes.bool,

it is not added

What changes do you think we should make in order to solve the problem?

Add submitOnEnter={!Browser.isMobile()} prop here

App/src/pages/PrivateNotes/PrivateNotesEditPage.js

Line 142 in 6d86d5a

<TextInput

Above change will ensure that enter behavior gets updated for desktop browsers and for mobile apps only.

What alternative solutions did you explore? (Optional)

N/A

[cubuspl42]

@ayazalavi Does it do any harm to add submitOnEnter for mobile browsers too? Don't we support a rare but possible scenario like an Android phone/tablet with a Bluetooth hardware keyboard + mobile Chrome?

[dukenv0307]

@cubuspl42 Actually, we use submitOnEnter={!Browser.isMobile()} in other page and this PR introduce this #27702

[cubuspl42]

I asked also on Slack

[ayazalavi]

@cubuspl42, I believe this form submission behavior is intended for platforms other than mobile browsers. Mobile browsers have different form submission behavior due to the lack of implementation for interactions between soft keyboards and HTML forms in the app. Please take a look at this issue for more information: Link to Issue #28569.

[melvin-bot]

@cubuspl42 Huh... This is 4 days overdue. Who can take care of this?

[cubuspl42]

@m-natarajan Let's close this. This might be intended and in another thread we decided that private notes are not a priority as they are mostly an internal feature.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

I agree with @cubuspl42 and I believe this page is being revamped anyways, so let's close this for now.