[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] Chat - No error mesage when trying to send a corrupted file, only red dot in LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #25557

Action Performed:

Pre-requisite: user must be logged in

1. Go to any chat
2. Send a corrupted file

Expected Result:

There should be an error message saying that there was a problem sending the file

Actual Result:

There is no error message, only the red dot appears in LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.76.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6222456_1696279003812.Bogb2868_1_.mp4

Bug6222456_1696279003807.1696274050416_bandicam_2023-10-02_15-13-24-257.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[francoisl]

I can reproduce the issue on staging and dev.

@cubuspl42 any ideas how to resolve this, or should we revert #25557 for now?

[mountiny]

cc @situchan from the PR as well, if we confirm the revert fixes it, can you please handle the revert to proactively clear the deploy blockers? @cubuspl42 wont be online until EU morning. Thanks!

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[marcaaron]

FWIW I tried the revert and it did not solve the issue.

[francoisl]

Same here. I'm attempting a git bisect to isolate where the regression came from but having a hard time because for some commits to test, the app just crashes. I'll try to narrow it down a bit more and then check the diff.

[francoisl]

Hmm if I revert #26729 locally, it fixes the issue. Not sure what to make of this yet, as the change seems unrelated 👀

[marcaaron]

See my findings here -> #28656 (comment)

[marcaaron]

I bet the message with error is just sorted to the top and hidden like the "Uploading attachment..." text 😄

That was a fun one 😂

[francoisl]

Haha nice. Yeah both our blockers look related.

Happy to send you a revert PR if you haven't already one in the works, or I can review yours.

[marcaaron]

I'll check yours - I made a branch but did not raise a PR

[cubuspl42]

I'm trying to catch up. So did reverting #25557 help or not?

[mountiny]

@cubuspl42 no it was different PR

[cubuspl42]

@mountiny So will we revert-revert #25557?

[mountiny]

It was not reverted #28671, the PR was closed, not merged

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix: User experienced big delay when posting the messages" #28673

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.77-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Fix: User experienced big delay when posting the messages" #28673

If no regressions arise, payment will be issued on 2023-10-12. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@francoisl] The PR that introduced the bug has been identified. Link to the PR:Fix: User experienced big delay when posting the messages #26729
• [@francoisl] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Fix: User experienced big delay when posting the messages #26729 (comment)
• [@francoisl] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@francoisl] Determine if we should create a regression test for this bug.
• [@francoisl] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kbecciv]

Issue is not reproducible on build v1.3.96-10

Recording.5242.mp4

[situchan]

@kbecciv yes, it's expected not reproducible on staging. Did you also not reproduce on this build?

[kbecciv]

Checking special build, will update you shortly

[kbecciv]

Not reproduced on special build

Recording.5244.mp4