[HOLD for payment 2023-10-10] [$250] App crashing when clicked send message from Fub menu quickly after sign in from google

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Logout from App
2. Sign in with google.
3. Click on fab menu "+" button and then click on send message.

Expected Result:

App is not crashing

Actual Result:

App is crashing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75.2
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-29.at.5.12.23.PM.mov

Screen.Recording.2023-09-29.at.5.37.34.PM.mov

Recording.4798.mp4

Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695988989758259

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0139365f545cd489dc
• Upwork Job ID: 1708418024558505984
• Last Price Increase: 2023-10-01
• Automatic offers:
• fedirjh | Contributor | 26964681
• ishpaul777 | Reporter | 26964683
• mkhutornyi | Contributor | 26964704

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[ishpaul777]

Just a quick note - App crashes only when send message is clicked when LHN and Report loading skelaton is visible.

[mkhutornyi]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crashes when deep link Send message page after login

What is the root cause of that problem?

As soon as login, there's no reportID in route param.
And this function returns null string

App/src/pages/home/ReportScreen.js

Lines 138 to 140 in 5fd69da

	function getReportID(route) {
	return String(lodashGet(route, 'params.reportID', null));
	}

null string doesn't meet this condition:

App/src/pages/home/ReportScreen.js

Lines 244 to 246 in 5fd69da

	if (!reportIDFromPath) {
	return;
	}

So OpenReport api is called with null reportID

What changes do you think we should make in order to solve the problem?

Solution1: set fallback value to empty string (``)

    return String(lodashGet(route, 'params.reportID', ''));

Solution 2: As Solution 1 might return all reports if subscribe onyx with report_, so better to leave null string as is. So just update this condition:

        if (!reportIDFromPath || reportIDFromPath === 'null' || reportIDFromPath === '0') {

We can make util function isValidReportID(reportID) for this.

[mountiny]

@mkhutornyi Can you point out what change in staging aused this blocker as part of your proposal?

[mkhutornyi]

I confirmed that #26772 caused this.

[fedirjh]

@mkhutornyi The Second solution makes sense, can we also fix the crash inside ReportUtils.isReportDataReady?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0139365f545cd489dc

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

[melvin-bot]

Upwork job price has been updated to $250

[mkhutornyi]

PR is ready

[melvin-bot]

🎯 ⚡️ Woah @fedirjh / @mkhutornyi, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @mkhutornyi got assigned: 2023-10-01 09:50:17 Z
• when the PR got merged: 2023-10-02 16:03:38 UTC

On to the next one 🚀

[mountiny]

Confirmed this works in staging now.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] prevent OpenReport api call with "null" report #28560

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Contributor)
• @mkhutornyi requires payment offer (Contributor)
• @ishpaul777 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] prevent OpenReport api call with "null" report #28560

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @fedirjh requires payment offer (Contributor)
• @mkhutornyi requires payment offer (Contributor)
• @ishpaul777 requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mountiny]

The regression PR was identified #26772

We dont need regression tests for this, this is a core flow which is covered already and crash would be caught.

Payment summary:

$250 to @mkhutornyi for a deploy blocker fix to be paid. Fedi has been C+ on the original PR so I think no payment here
$50 to @ishpaul777 for reporting

[fedirjh]

The regression PR was identified #26772

Actually, this PR #22260 has introduced the root cause of this bug, it remained hidden until #26772 was merged.

[muttmuure]

Everyone is paid

[mountiny]

Thanks!