[$500] IOU-Editing distance request, new message is not shown but for request money, new message shown

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Tap fab
3. Tap request money
4. Tap distance
5. Enter start and finish points
6. Tap next and select a workspace
7. Tap show more and enter all fields
8. Tap request amount
9. Tap on distance request and open report page
10. Change amount/date/category and note the changes made message shown below
11. Navigate back to LHN
12. Tap fab-manual
13. Tap request money
14. Enter an amount
15. Select any user
16. Tap request amount
17. Tap IOU transaction to open report page
18. Change merchant/amount /description and save it.
19. Note the changes made messages shown below

Expected Result:

In changes made messages shown below, the "new message" green line display must be consistent for both request and distance request

Actual Result:

For editing distance request, "new message" green line is not shown but for request money, "new message" green line is shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6218875_1695982740471.gree_compress_1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0162a10f4c446abf35
• Upwork Job ID: 1708383269164470272
• Last Price Increase: 2023-12-12

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @AndrewGable (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Reproduced on build 1.3.75.2

reproduced.mp4

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0162a10f4c446abf35

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[mountiny]

I dont think this needs to be deploy blocker but still something to look at, by the look of things it might be backend issue actually but both edit money request and update distance request modify the expenses in a same way so I am not sure why this shoul dbe different or whether it is reliably reproducible

Making this external so people can look into this

[alexpensify]

Update: Waiting for proposals here

[alexpensify]

Update: Waiting for proposals here

[AndrewGable]

@alexpensify - Can you reproduce? If not let's close.

[alexpensify]

Tomorrow, I'll run one more test.

[melvin-bot]

@AndrewGable @alexpensify @aimane-chnaif this issue is now 3 weeks old. There is one more week left before this issue breaks WAQ and will need to go internal. What needs to happen to get a PR in review this week? Please create a thread in #expensify-open-source to discuss. Thanks!

[alexpensify]

I tested and can't replicate -- closing!

[aimane-chnaif]

@alexpensify this is still reproducible to me. Tested on iOS but should happen on all platforms

Manual request: (new message)

Screen.Recording.2023-11-06.at.8.27.31.AM.mov

Distance request: (no new message)

Screen.Recording.2023-11-06.at.8.29.31.AM.mov

[alexpensify]

I haven't had time to test but will review when I'm back from OOO.

[aimane-chnaif]

@alexpensify bump to reopen

[alexpensify]

@aimane-chnaif thanks for the reminder. To confirm, is this issue still on iOS or all platforms?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

@aimane-chnaif bumping this question again to prepare for proposals, thanks!

[aimane-chnaif]

checking

[alexpensify]

@aimane-chnaif any update here?

[aimane-chnaif]

The original issue (new message marker issue) was fixed but still unread in LHN.
So the bug is that: unread in LHN while read in chat. This happens on all types of money requests.
Should we fix this here? I tried to find duplicate GHs but not found

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

@AndrewGable - based on @aimane-chnaif's feedback, should we fix or start a bigger discussion in the Open Source room?

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[alexpensify]

Daily Update: Still waiting for feedback if we fix this one

[alexpensify]

Daily Update: Still waiting for feedback if we fix this one

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

Since this has not been reproducible in the latest tests, I'm going to close it out.