[HOLD for payment 2023-10-18] [$500] Chat - No loading animation when scrolling through chat history offline

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open Desktop App or go to staging.new.expensify.com
2. Login to any account
3. Open chat with long history
4. Go Offline
5. Scroll chat history that has been cached

Expected Result:

Loading animation will be shown when the cached part of the chat ends

Actual Result:

Loading animation is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.75-0

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6218642_1695966451095.Chat-offline-no-loading-animation.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0115f790294bf26093
• Upwork Job ID: 1708780525432848384
• Last Price Increase: 2023-10-02
• Automatic offers:
• situchan | Reviewer | 27034754
• bernhardoj | Contributor | 27034757

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @cristipaval (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[kbecciv]

Reproduced with build 1.3.75-3

28466.Desktop.1-3-75-3.mp4

[cristipaval]

I think this regression was introduced by this PR, but I would revert it because it's a big one and brings performance optimizations. I will remove the deploy blocker and fix this as a regular issue. It's a minor UI bug reproducible in a corner(ish) use case.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no skeleton view when scrolling to the top of the chat to load more messages.

What is the root cause of that problem?

The load more skeleton will show if isLoadingMoreReportActions is true.

App/src/pages/home/report/ReportActionsList.js

Lines 331 to 333 in b5dda00

	if (isLoadingMoreReportActions) {
	return <ReportActionsSkeletonView />;
	}

When we load more chats, it will call Report.readOldestActions that will optimistically set REPORT onyx isLoadingMoreReportActions to true.

App/src/pages/home/report/ReportActionsView.js

Lines 158 to 159 in b5dda00

	// Retrieve the next REPORT.ACTIONS.LIMIT sized page of comments
	Report.readOldestAction(reportID, oldestReportAction.reportActionID);

App/src/libs/actions/Report.js

Lines 762 to 777 in b5dda00

	API.read(
	'ReadOldestAction',
	{
	reportID,
	reportActionID,
	},
	{
	optimisticData: [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT}${reportID}`,
	value: {
	isLoadingMoreReportActions: true,
	},
	},
	],

However, after this PR, we retrieve isLoadingMoreReportActions from REPORT_METADATA onyx, so the value is never changed and stays false.

App/src/pages/home/ReportScreen.js

Lines 429 to 433 in b5dda00

	<ReportActionsView
	reportActions={reportActions}
	report={report}
	isLoadingReportActions={reportMetadata.isLoadingReportActions}
	isLoadingMoreReportActions={reportMetadata.isLoadingMoreReportActions}

App/src/pages/home/ReportScreen.js

Lines 486 to 492 in b5dda00

	reportMetadata: {
	key: ({route}) => `${ONYXKEYS.COLLECTION.REPORT_METADATA}${getReportID(route)}`,
	initialValue: {
	isLoadingReportActions: false,
	isLoadingMoreReportActions: false,
	},
	},

What changes do you think we should make in order to solve the problem?

Change the onyx key from REPORT to REPORT_METADATA in Report.readOldestActions

I noticed that previously, the load more chat skeleton only showed 3 messages skeleton, but now it shows many skeletons that cover up the whole screen

[cristipaval]

I think we can make this one External

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0115f790294bf26093

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @situchan (External)

[melvin-bot]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @situchan 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @situchan

[melvin-bot]

🎯 ⚡️ Woah @situchan / @bernhardoj, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @bernhardoj got assigned: 2023-10-05 09:50:55 Z
• when the PR got merged: 2023-10-06 21:16:48 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.80-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix load more message skeletons aren't showing #28905

If no regressions arise, payment will be issued on 2023-10-18. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @bernhardoj requires payment offer (Contributor)
• @situchan requires payment offer (Reviewer)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[JmillsExpensify]

Payment summary:

• Issuer reporter: N/A
• Contributor: @bernhardoj $750
• Contributor+: @situchan $750

[JmillsExpensify]

@situchan Do you mind completing the BZ checklist above?

[melvin-bot]

@JmillsExpensify, @cristipaval, @bernhardoj, @situchan Huh... This is 4 days overdue. Who can take care of this?

[cristipaval]

bump @situchan

[situchan]

I was not able to find offending PR.
Recent PR should have reverted the changes made in #26772 but git blame shows nothing. @bernhardoj it would be great if you can help finding.

As this was caught by Applause team, no need another regression test.

[JmillsExpensify]

Thanks for that. Payment issued. Closing since we're also covered on regression tests.