Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAML SSO in NewDot - iOS and Android UI #28217

Closed
sakluger opened this issue Sep 26, 2023 · 20 comments
Closed

SAML SSO in NewDot - iOS and Android UI #28217

sakluger opened this issue Sep 26, 2023 · 20 comments
Assignees
@sakluger @NikkiWines
Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2

Comments

@sakluger
Copy link
Contributor

Tracking GH issue: https://github.com/Expensify/Expensify/issues/294583
Relevant design doc section: https://docs.google.com/document/d/1xa68adybahTxucjSqvPJ2MZCZvaBoP1_vtYk5hTikGU/edit#heading=h.72o1331fkwa2
@sakluger sakluger added the Daily KSv2 label Sep 26, 2023
@melvin-bot melvin-bot bot added the Overdue label Sep 28, 2023
@NikkiWines
Copy link
Contributor

Focusing on web / mweb first, then on platform specific logic

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@sakluger, @NikkiWines Whoops! This issue is 2 days overdue. Let's get this updated quick!

@sakluger
Copy link
Contributor Author

sakluger commented Oct 2, 2023

No updates, @NikkiWines what's the ETA on this one? Would it still make sense to ask Infinite Red to help with this one?

@melvin-bot melvin-bot bot removed the Overdue label Oct 2, 2023
@NikkiWines
Copy link
Contributor

Similar to the desktop update - we're still looking at getting web/mweb over the line so it would be good to get external/agency eyes on the platform specific logic

@melvin-bot melvin-bot bot added the Overdue label Oct 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@sakluger, @NikkiWines Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@sakluger
Copy link
Contributor Author

sakluger commented Oct 7, 2023

Not overdue, we're just working on other platforms first.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 7, 2023
@NikkiWines
Copy link
Contributor

See update here

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 10, 2023
@sakluger
Copy link
Contributor Author

@NikkiWines you said that you started working on this one?

@melvin-bot melvin-bot bot removed the Overdue label Oct 13, 2023
@NikkiWines NikkiWines mentioned this issue Oct 13, 2023
Merged
47 tasks
@NikkiWines
Copy link
Contributor

Yep, should be handled in #29526 ^^

@melvin-bot melvin-bot bot added the Overdue label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@sakluger, @NikkiWines Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@NikkiWines
Copy link
Contributor

iOS/Android PR is in the works!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@sakluger
Copy link
Contributor Author

Not overdue, @NikkiWines is actively working on the PR.

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@sakluger
Copy link
Contributor Author

It looks like @NikkiWines is making progress on the PR, I see new commits from two hours ago.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@NikkiWines
Copy link
Contributor

UI is looking good and the backend PR is in review. Hoping to get #30027 updated + merged into my branch so we can be all set to merge #29526 once the backend changes are live.

@NikkiWines NikkiWines added NewFeature Something to build that is a new item. Engineering labels Oct 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 25, 2023

Current assignee @sakluger is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 25, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 2, 2023
@NikkiWines
Copy link
Contributor

Still waiting on https://github.com/Expensify/Web-Expensify/pull/39366 to be reviewed

@melvin-bot melvin-bot bot removed the Overdue label Nov 2, 2023
@NikkiWines
Copy link
Contributor

https://github.com/Expensify/Web-Expensify/pull/39366 is merged, hoping to get #29526 reviewed and merged next week!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Nov 13, 2023
@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Dec 7, 2023
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Dec 7, 2023

This issue has not been updated in over 15 days. @sakluger, @NikkiWines eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@NikkiWines NikkiWines mentioned this issue Dec 8, 2023
Closed
@NikkiWines
Copy link
Contributor

Created an issue to handle payment for PR review: #32701

@NikkiWines
Copy link
Contributor

Oops this can be closed now!

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sakluger sakluger

@NikkiWines NikkiWines

Labels
Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sakluger @NikkiWines