Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-02] Add IDs to more elements for E2E testing purposes #27968

Closed
roryabraham opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Task Weekly KSv2

Comments

@roryabraham
Copy link
Contributor

Problem

Many of our elements do not have stable IDs, making them difficult to locate with E2E testing selectors.

Solution

Add some IDs requested by Applause to make it easier to write tests:

https://expensify.slack.com/archives/C9YU7BX5M/p1695308536368729?thread_ts=1692292292.149339&cid=C9YU7BX5M

@roryabraham roryabraham self-assigned this Sep 22, 2023
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 Weekly KSv2 labels Sep 22, 2023
@melvin-bot melvin-bot bot changed the title Add IDs to more elements for E2E testing purposes [HOLD for payment 2023-10-02] Add IDs to more elements for E2E testing purposes Sep 25, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@roryabraham
Copy link
Contributor Author

No payments due here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Reviewing Has a PR in review Task Weekly KSv2
Projects
None yet
Development

No branches or pull requests

1 participant