Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-30] [Polish] Update RBR behavior for failed Smartscanned receipts #27633

Closed
Gonals opened this issue Sep 18, 2023 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff

Comments

@Gonals
Copy link
Contributor

Gonals commented Sep 18, 2023

Coming from here

We need to make some changes so that the red dot in the LHN:

  • No longer show it in the chat report row
  • Show it in the IOU report row JUST for the requester
  • Show it in the Transction row JUST for the requester
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~019acc23cb45b6e738
  • Upwork Job ID: 1703639849200287744
  • Last Price Increase: 2023-09-18
@Gonals Gonals added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff labels Sep 18, 2023
@Gonals Gonals self-assigned this Sep 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Job added to Upwork: https://www.upwork.com/jobs/~019acc23cb45b6e738

@melvin-bot
Copy link

melvin-bot bot commented Sep 18, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @0xmiroslav (Internal)

@melvin-bot melvin-bot bot added the Overdue label Sep 26, 2023
@Gonals Gonals added the Reviewing Has a PR in review label Sep 29, 2023
@melvin-bot melvin-bot bot removed the Overdue label Sep 29, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 23, 2023
@melvin-bot melvin-bot bot changed the title [Polish] Update RBR behavior for failed Smartscanned receipts [HOLD for payment 2023-10-30] [Polish] Update RBR behavior for failed Smartscanned receipts Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

  • @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Oct 29, 2023
Copy link

melvin-bot bot commented Nov 1, 2023

@Gonals, @0xmiroslav Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@0xmiros
Copy link
Contributor

0xmiros commented Nov 1, 2023

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Nov 1, 2023
Copy link

melvin-bot bot commented Nov 8, 2023

@Gonals, @0xmiroslav Still overdue 6 days?! Let's take care of this!

@trjExpensify
Copy link
Contributor

Straight $500 for the internal PR review here? @0xmiroslav are you tracking the payment request somewhere?

@0xmiros
Copy link
Contributor

0xmiros commented Nov 8, 2023

yes, let's close this. Thanks

@trjExpensify
Copy link
Contributor

Sounds good! Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

3 participants