[HOLD for payment 2023-09-21] Attachment - Keyboard does not reopen when tap Back button on Gallery page

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #23994

Action Performed:

1. Open any chat
2. Focus the composer to open the keyboard
3. Tap plus icon in the composer, and then click Add Attachment
4. Select "Files" from Choose an action modal
5. Tap the backdrop to exit

Expected Result:

The keyboard should reopen

Actual Result:

Keyboard does not reopen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.57-0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

az_recorder_20230824_125152.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internl Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Christinadobrzyn]

Might be related to - #13922

[Christinadobrzyn]

Might be fixed with #13922 (comment) so gonna Hold this one and do more testing after #13922 (comment) is deployed.

[Christinadobrzyn]

On hold for - #13922 (comment)

[situchan]

@Christinadobrzyn can you please add Engineering label? No engineer assigned as reviewer in #26221

[melvin-bot]

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Christinadobrzyn]

Hey @aldo-expensify can you review #26221

[aldo-expensify]

Is this issue not in HOLD for 13922 anymore?

[situchan]

Is this issue not in HOLD for 13922 anymore?

correct. PR which fixes #13922 was deployed to production on Aug 29

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• reopen keyboard when tap back on gallery page. #26221

If no regressions arise, payment will be issued on 2023-09-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aldo-expensify] The PR that introduced the bug has been identified. Link to the PR:
• [@aldo-expensify] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aldo-expensify] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aldo-expensify] Determine if we should create a regression test for this bug.
• [@aldo-expensify] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

just prepping this for payment...

• Are we paying this or was it a regression?
• @situchan you were the C+ or contributor?
• @aldo-expensify do you think we need a regression test on this?

[situchan]

I'd say this is follow-up of #13922 rather than regression. Context: #13922 (comment)
No payment is needed here. The work on this GH should be covered enough in #13922 's payment.

[aldo-expensify]

Agree with @situchan 's assessment.

[Christinadobrzyn]

Sounds good! thanks @situchan and @aldo-expensify! I will close this without payment - payment will be in #13922