WS - Members - Avatars group on final screen moves to the left if admin invites more 8 users #22685

lanitochka17 · 2023-07-11T20:07:54Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

Open and login with expensifail account to staging.new.expensify.com or Expensify App
Go to existing or create new workspace
Go to Workspace > Members
Click / Tap 'Invite'
Select more then 8 users
Click 'Next'

Expected Result:

The avatar group on the final screen is always in the center

Actual Result:

The avatars group on final screen moves to the left if admin invites more 8 users
The shift to the left gets bigger with each user added

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: 1.3.39.5

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6124175_WS-Invite-users-avatars-cut.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

melvin-bot · 2023-07-11T20:07:59Z

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-07-11T20:08:01Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

StevenKKC · 2023-07-11T20:48:48Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Avatars group on final screen moves to the left if admin invites more 8 users.

What is the root cause of that problem?

Avatar group's width is calculated as below.

App/src/components/MultipleAvatars.js

Lines 138 to 144 in 702d8e2

    
           if (props.icons.length > 4) { 
        
               const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length; 
        
               width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2); 
        
           } else { 
        
               // one avatar width + overlaping avatar sizes + border space 
        
               width = oneAvatarSize.width + overlapSize * 2 * (props.icons.length - 1) + oneAvatarBorderWidth * (props.icons.length * 2); 
        
           }

App/src/components/MultipleAvatars.js

Lines 91 to 93 in 702d8e2

    
           // Slice the icons array into two rows 
        
           const firstRow = props.icons.slice(rowSize); 
        
           const secondRow = props.icons.slice(0, rowSize);

If have more than 8 avatar, length would be greater than props.maxAvatarsInRow (4).
So avatar group moves to the left.

What changes do you think we should make in order to solve the problem?

Avatar group's width should be equal to or less than props.maxAvatarsInRow.
We can change code as below.

-   const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length;
+   const length = Math.min(avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length, props.maxAvatarsInRow);

What alternative solutions did you explore? (Optional)

None.

DrLoopFall · 2023-07-12T10:36:48Z

There's also another issue #22632, connected to this, even though the issues are different, the root cause remains the same.
I've made a proposal there which would solve both issues, I'll also leave a proposal below just in case.

DrLoopFall · 2023-07-12T10:37:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace members avatars group on the final screen moves to the left if the admin invites more than 8 users

What is the root cause of that problem?

We are using left for positioning/shifting avatars, which causes it to use more space than required.

App/src/styles/StyleUtils.js

Line 906 in 702d8e2

left: -(overlapSize * index),

App/src/styles/StyleUtils.js

Line 923 in 702d8e2

left: -(oneAvatarSize.width * 2 + oneAvatarBorderWidth * 2),

Also, currently, we are calculating the width, as a workaround, which is also a part of the problem in this issue.

@stitesExpensify I think the width was set as a workaround for the issue described in my proposal (the 2nd issue)

We are using left for positioning/shifting avatars but the PressableWithoutFeedback itself is not shifted, which causes it to be clickable in both the original and shifted positions.

If we use margin-left instead, we can remove the width, which may prevent any future issues.

App/src/components/MultipleAvatars.js

Lines 138 to 144 in 702d8e2

    
           if (props.icons.length > 4) { 
        
               const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length; 
        
               width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2); 
        
           } else { 
        
               // one avatar width + overlaping avatar sizes + border space 
        
               width = oneAvatarSize.width + overlapSize * 2 * (props.icons.length - 1) + oneAvatarBorderWidth * (props.icons.length * 2); 
        
           }

What changes do you think we should make in order to solve the problem?

Use margin-left instead of left for positioning the avatar.

// in getHorizontalStackedAvatarStyle
- left: -(overlapSize * index)
+ marginLeft: index > 0 ? -overlapSize : 0

// in getHorizontalStackedOverlayAvatarStyle
- left: -(oneAvatarSize.width * 2 + oneAvatarBorderWidth * 2)
+ marginLeft: -(oneAvatarSize.width + oneAvatarBorderWidth * 2)

We should also need to remove the width, as we don't need it anymore, because this proposal also removes the need for the workaround as it fixes the issue in the root, and removing it may prevent future issues like this.

App/src/components/MultipleAvatars.js

Lines 138 to 144 in 702d8e2

    
           if (props.icons.length > 4) { 
        
               const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length; 
        
               width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2); 
        
           } else { 
        
               // one avatar width + overlaping avatar sizes + border space 
        
               width = oneAvatarSize.width + overlapSize * 2 * (props.icons.length - 1) + oneAvatarBorderWidth * (props.icons.length * 2); 
        
           }

melvin-bot · 2023-07-14T20:09:12Z

@johncschuster Whoops! This issue is 2 days overdue. Let's get this updated quick!

huzaifa-99 · 2023-07-17T14:20:02Z

My proposal here fixes this issue, reposting for visibility

Proposal

Please re-state the problem that we are trying to solve in this issue.

We want workspace icons to be aligned to right.

What is the root cause of that problem?

We do a different kind of width calculation when there are more than 4 icons, but at a single time we only display 4 icons. The extra width moves the icons to left.

App/src/components/MultipleAvatars.js

Lines 142 to 145 in 6e5b07c

    
           if (props.icons.length > 4) { 
        
               const length = avatarRows.length > 1 ? Math.max(avatarRows[0].length, avatarRows[1].length) : avatarRows[0].length; 
        
               width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2); 
        
           } else {

What changes do you think we should make in order to solve the problem?

We should update the width calculation here. Since we only display a max of 4 icons, we can remove the length calculation and use 4 directly (which comes from props.maxAvatarsInRow), and simplify this whole block with this condition

const length = Math.min(props.maxAvatarsInRow, props.icons.length)
width = oneAvatarSize.width + overlapSize * 2 * (length - 1) + oneAvatarBorderWidth * (length * 2);

What alternative solutions did you explore? (Optional)

N/A

melvin-bot · 2023-07-18T20:09:24Z

@johncschuster 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

johncschuster · 2023-07-18T21:16:44Z

If the root cause will be fixed in another issue, does this issue need to remain open?

(I'm not sure, so I'm asking in Slack)

johncschuster · 2023-07-20T14:02:47Z

bumping my question above

Santhosh-Sellavel · 2023-07-20T23:07:12Z

@johncschuster Yeah can close this one in favor of #22632

johncschuster · 2023-07-21T21:00:27Z

Thanks, @Santhosh-Sellavel!

lanitochka17 added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jul 11, 2023

melvin-bot bot assigned johncschuster Jul 11, 2023

StevenKKC mentioned this issue Jul 12, 2023

[HOLD for payment 2023-08-07] [$1000] Workspace - Workspace icons are aligned to the left #22632

Closed

6 tasks

melvin-bot bot added the Overdue label Jul 13, 2023

jliexpensify mentioned this issue Jul 17, 2023

[HOLD for payment 2023-08-03] [$1000] Web - The tooltip shows multiple/all the selected users when hovering over the overlayed avatar #22951

Closed

6 tasks

DrLoopFall mentioned this issue Jul 17, 2023

[$1000] Web - Split bill icons are aligned to the left #22993

Closed

6 tasks

Nodebrute mentioned this issue Jul 17, 2023

mweb - Split bill amount (cents) overlaps with avatar in split bill report #23039

Closed

6 tasks

melvin-bot bot removed the Overdue label Jul 18, 2023

johncschuster closed this as completed Jul 21, 2023

conorpendergrast mentioned this issue Jul 26, 2023

Avatars are cut to the side on 'Add message' page when user invites more than 12 user a time #23605

Closed

6 tasks

DrLoopFall mentioned this issue Jul 26, 2023

Fix MulitpleAvatars alignment #23580

Merged

58 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WS - Members - Avatars group on final screen moves to the left if admin invites more 8 users #22685

WS - Members - Avatars group on final screen moves to the left if admin invites more 8 users #22685

lanitochka17 commented Jul 11, 2023 •

edited

Loading

melvin-bot bot commented Jul 11, 2023

melvin-bot bot commented Jul 11, 2023

StevenKKC commented Jul 11, 2023 •

edited

Loading

DrLoopFall commented Jul 12, 2023

DrLoopFall commented Jul 12, 2023

melvin-bot bot commented Jul 14, 2023

huzaifa-99 commented Jul 17, 2023 •

edited

Loading

melvin-bot bot commented Jul 18, 2023

johncschuster commented Jul 18, 2023

johncschuster commented Jul 20, 2023

Santhosh-Sellavel commented Jul 20, 2023

johncschuster commented Jul 21, 2023

WS - Members - Avatars group on final screen moves to the left if admin invites more 8 users #22685

WS - Members - Avatars group on final screen moves to the left if admin invites more 8 users #22685

Comments

lanitochka17 commented Jul 11, 2023 • edited Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Jul 11, 2023

melvin-bot bot commented Jul 11, 2023

Bug0 Triage Checklist (Main S/O)

StevenKKC commented Jul 11, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

DrLoopFall commented Jul 12, 2023

DrLoopFall commented Jul 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Jul 14, 2023

huzaifa-99 commented Jul 17, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

melvin-bot bot commented Jul 18, 2023

johncschuster commented Jul 18, 2023

johncschuster commented Jul 20, 2023

Santhosh-Sellavel commented Jul 20, 2023

johncschuster commented Jul 21, 2023

lanitochka17 commented Jul 11, 2023 •

edited

Loading

StevenKKC commented Jul 11, 2023 •

edited

Loading

huzaifa-99 commented Jul 17, 2023 •

edited

Loading