Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-28] Update Expense Request View #22333

Closed
grgia opened this issue Jul 6, 2023 · 17 comments
Closed

[HOLD for payment 2023-07-28] Update Expense Request View #22333

grgia opened this issue Jul 6, 2023 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2

Comments

@grgia
Copy link
Contributor

grgia commented Jul 6, 2023

Part 2 of #20486 (comment)
Related to #20486

image

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~018b93f70cc206833c
  • Upwork Job ID: 1676899872247611392
  • Last Price Increase: 2023-07-06
@grgia grgia added Daily KSv2 Internal Requires API changes or must be handled by Expensify staff labels Jul 6, 2023
@grgia grgia self-assigned this Jul 6, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

Job added to Upwork: https://www.upwork.com/jobs/~018b93f70cc206833c

@melvin-bot
Copy link

melvin-bot bot commented Jul 6, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Santhosh-Sellavel (Internal)

@grgia
Copy link
Contributor Author

grgia commented Jul 10, 2023

PR Created

@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Overdue labels Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 18, 2023

@grgia, @Santhosh-Sellavel Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2023

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot
Copy link

melvin-bot bot commented Jul 20, 2023

@grgia, @Santhosh-Sellavel Huh... This is 4 days overdue. Who can take care of this?

@Santhosh-Sellavel
Copy link
Collaborator

Not overdue PR is merged!

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jul 21, 2023
@melvin-bot melvin-bot bot changed the title Update Expense Request View [HOLD for payment 2023-07-28] Update Expense Request View Jul 21, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 21, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 27, 2023
@Santhosh-Sellavel
Copy link
Collaborator

@grgia Can you or ask a BZ to leave a comment mentioning the amount to be paid for review? So I can request on ND, thanks!

@melvin-bot melvin-bot bot added the Overdue label Jul 31, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 1, 2023

@grgia, @Santhosh-Sellavel Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@Santhosh-Sellavel
Copy link
Collaborator

@grgia bump!

@melvin-bot melvin-bot bot removed the Overdue label Aug 1, 2023
@Santhosh-Sellavel
Copy link
Collaborator

Santhosh-Sellavel commented Aug 2, 2023

@Expensify/bug-zero Can anyone sum up the payment for the internal PR review? So I can proceed with the payment request on ND. thanks!

@Christinadobrzyn Christinadobrzyn self-assigned this Aug 3, 2023
@Christinadobrzyn
Copy link
Contributor

I can help with this!

I don't see that a speed bonus applies to this PR, @Santhosh-Sellavel can you confirm if you qualify for a speed bonus?

@Santhosh-Sellavel
Copy link
Collaborator

Yes, no speed bonus here @Christinadobrzyn, just the review fee!

@grgia grgia added Weekly KSv2 and removed Daily KSv2 labels Aug 3, 2023
@Christinadobrzyn
Copy link
Contributor

Christinadobrzyn commented Aug 3, 2023

Thanks @Santhosh-Sellavel!

Payouts due:

Contributor+: $1000 @Santhosh-Sellavel
Eligible for 50% #urgency bonus? NA - internal

@JmillsExpensify
Copy link

Reviewed details for @Santhosh-Sellavel. These details are accurate based on summary from Business Reviewer and are now approved for payment in NewDot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Internal Requires API changes or must be handled by Expensify staff Weekly KSv2
Projects
None yet
Development

No branches or pull requests

4 participants