[HOLD for payment 2023-07-20] Dev - Console error on opening detail page by clicking on mentioned user

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login to ND
2. Go to any conversation
3. Type @ and mention any user (open console)
4. Click on any particular mentioned user -> detail page should open
5. Notice on opening details page throw error on console

Expected Result:

No console error should appear

Actual Result:

Console error appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.30-0
Reproducible in staging?: dev
Reproducible in production?: dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @dhairyasenjaliya
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687326565653439

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[kavimuru]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dev - Console error on opening detail page by clicking on mentioned user

What is the root cause of that problem?

The root cause is on DetailsPage we are using PressableWithoutFocus component and on that we passing style as an array instead of object that the cause of the warning

What changes do you think we should make in order to solve the problem?

We should pass style as an object rather than array just like we are passing everywhere else

// DetailsPage.js
<PressableWithoutFocus
-  style={styles.noOutline}
+  style={[styles.noOutline]}
   onPress={show}
>

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Console error on opening detail page by clicking on mentioned user

What is the root cause of that problem?

PressableWithoutFocus component style prop is expecting the data of type array of objects whereas we are passing only object for DetailsPage. This is causing the console warning issue.

App/src/components/Pressable/PressableWithoutFocus.js

Line 19 in ae8a751

style: PropTypes.arrayOf(PropTypes.object),

App/src/pages/DetailsPage.js

Line 151 in ae8a751

style={styles.noOutline}

What changes do you think we should make in order to solve the problem?

We should pass the object within an array that will meet the expected type and the error/console warning gets resolved.
style={[styles.noOutline]}

[dylanexpensify]

Posting for repro w/dev

[dylanexpensify]

bumped request in slack

[dylanexpensify]

reviewing today and posting next steps!

[dylanexpensify]

@kavimuru is this still occurring?

[dylanexpensify]

ok pinging original author for minor fix of brackets.

[dylanexpensify]

context https://expensify.slack.com/archives/C01SKUP7QR0/p1687949082476329

[kavimuru]

@dylanexpensify this is happening in Dev only and I couldn't check

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.39-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• PressableWithoutFocus followup - change style propType to be in line with GenericPressable type #22539

If no regressions arise, payment will be issued on 2023-07-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [] The PR that introduced the bug has been identified. Link to the PR:
• [] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [] Determine if we should create a regression test for this bug.
• [] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: