Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-07-17] Hide Send money from the front-end #21233

Closed
JmillsExpensify opened this issue Jun 21, 2023 · 14 comments
Closed

[HOLD for payment 2023-07-17] Hide Send money from the front-end #21233

JmillsExpensify opened this issue Jun 21, 2023 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Task

Comments

@JmillsExpensify
Copy link

Problem

Send money is a beta feature that we don't have immediate plans to launch, nor it is even finished. The thing is though, we're treating it as part of the platform even despite this, which creates a bunch of extra work and upkeep that sucks focus and urgency from reunification.

Solution

Let's hide Send money from from global create the only place where it currently exists. In addition, let's remove documentation related to Send Money on https://help.expensify.com/hubs/send-money.

@JmillsExpensify
Copy link
Author

cc @maddylewis what's the process for removing the documentation, once Send Money is removed?

@maddylewis
Copy link
Contributor

here are the instructions on how to delete an article - https://stackoverflowteams.com/c/expensify/questions/15144

@maddylewis
Copy link
Contributor

im not sure how to delete a hub off of the top of my head, but we're planning to delete/restructure the existing hubs so that will happen relatively soon via https://docs.google.com/document/d/1MjTYzA-uo7ShLjo8x3XLA7EkSAhx0Yc9W43PPnKV3co/edit.

i can track down how to delete a hub from the site in the meantime!

@maddylewis
Copy link
Contributor

@johncschuster - do you know how to delete a hub on the help site? i think we would need to delete/move the articles from the Send Money hub first and then we'd have to the option to delete a hub?

i was trying to work backwards using these instructions - https://stackoverflowteams.com/c/expensify/questions/15131

@marcaaron
Copy link
Contributor

👀 at this 🔜

@marcaaron
Copy link
Contributor

@maddylewis I will try to get @marcochavezf to help us with this. I made some edits for the docs if you want to take a look at what I did here. Mainly just removed all the references to "Send Money".

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Jul 4, 2023
@maddylewis
Copy link
Contributor

maddylewis commented Jul 10, 2023

@marcaaron - thanks, yep that LGTM.

@marcaaron
Copy link
Contributor

Just a heads up these changes are on staging now so we should be removing "Send money" in the next App release.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2023
@melvin-bot melvin-bot bot changed the title Hide Send money from the front-end [HOLD for payment 2023-07-17] Hide Send money from the front-end Jul 10, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jul 10, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@Santhosh-Sellavel
Copy link
Collaborator

Requested payment on ND

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 17, 2023
@anmurali
Copy link

Approved $1k for Santhosh for this PR

@melvin-bot melvin-bot bot added the Overdue label Jul 19, 2023
@marcaaron marcaaron added the Reviewing Has a PR in review label Jul 20, 2023
@melvin-bot melvin-bot bot removed the Overdue label Jul 20, 2023
@marcaaron marcaaron removed the Reviewing Has a PR in review label Jul 20, 2023
@marcaaron
Copy link
Contributor

Not Overdue

@Santhosh-Sellavel
Copy link
Collaborator

@marcaaron We can close this, payments are settled!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Task
Projects
None yet
Development

No branches or pull requests

5 participants