-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-07-17] Hide Send money
from the front-end
#21233
Comments
cc @maddylewis what's the process for removing the documentation, once |
here are the instructions on how to delete an article - https://stackoverflowteams.com/c/expensify/questions/15144 |
im not sure how to delete a hub off of the top of my head, but we're planning to delete/restructure the existing hubs so that will happen relatively soon via https://docs.google.com/document/d/1MjTYzA-uo7ShLjo8x3XLA7EkSAhx0Yc9W43PPnKV3co/edit. i can track down how to delete a hub from the site in the meantime! |
@johncschuster - do you know how to delete a hub on the help site? i think we would need to delete/move the articles from the i was trying to work backwards using these instructions - https://stackoverflowteams.com/c/expensify/questions/15131 |
👀 at this 🔜 |
@maddylewis I will try to get @marcochavezf to help us with this. I made some edits for the docs if you want to take a look at what I did here. Mainly just removed all the references to "Send Money". |
@marcaaron - thanks, yep that LGTM. |
Just a heads up these changes are on staging now so we should be removing "Send money" in the next App release. |
Send money
from the front-endSend money
from the front-end
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-07-17. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
Requested payment on ND |
Approved $1k for Santhosh for this PR |
Not Overdue |
@marcaaron We can close this, payments are settled! |
Problem
Send money
is a beta feature that we don't have immediate plans to launch, nor it is even finished. The thing is though, we're treating it as part of the platform even despite this, which creates a bunch of extra work and upkeep that sucks focus and urgency from reunification.Solution
Let's hide
Send money
from from global create the only place where it currently exists. In addition, let's remove documentation related toSend Money
on https://help.expensify.com/hubs/send-money.The text was updated successfully, but these errors were encountered: