Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat - Impossible to identify correct link in header as links are clickable across whole header #20857

Closed
3 of 6 tasks
lanitochka17 opened this issue Jun 15, 2023 · 4 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Jun 15, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #20484

Action Performed:

  1. Open any chat
  2. Send message
  3. Create thread
  4. Click thread header to the right from header details - a bit higher and lower

Expected Result:

It should be clear where it takes you if you click

Actual Result:

Header links are both clickable across the whole width of header. So it is hard to identify what you click - thread settings or link back to parent chat. Click higher - go to settings, click lower - parent chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.28.3

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6094481_video_84__3_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jun 15, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 15, 2023

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@francoisl
Copy link
Contributor

francoisl commented Jun 15, 2023

cc @chiragsalian since it's related to #20484.

I don't think this should be a blocker, looks like it's working as intended. Maybe it could use better styling, like displaying a "return arrow" (e.g. ↩) next to the "From ..." message, to make it clear that clicking/tapping it will take you back to the parent thread?

@mountiny mountiny added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jun 16, 2023
@mountiny
Copy link
Contributor

I agree, this is not a bug or a blocker, I think I will go ahead and close this @francoisl feel free to reopen if you feel strongly about the improvements, I think they might as well just come up in slack and we can handle that separately there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants