[HOLD for payment 2023-06-28] Member list "Select all" checkbox not working properly

[Beamanator]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to a workspace and invite few members
2. Click on select all check box and notice sometimes in the first try it works, but sometimes it doesn't. Try multiple times and see only the checkbox gets selected and not members.

Expected Result:

Select all checkbox should be woking properly, meaning it should select everyone (except maybe not the current user / owner)

Actual Result:

Select all checkbox not woking properly

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: main
Reproducible in staging?: N
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686829527636169

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[BeeMargarida]

Hi I'm Ana from Callstack - expert contributor group - I can work on this issue.

[BeeMargarida]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After inviting new members for a workspace and then selecting all elements in the workspace invite page, the select all would stop working.

What is the root cause of that problem?

We were saving the account IDs as numbers in the optimistic update, but then the backend would return them as strings. We were making the comparison with 2 different types, so when it should return checked true, it was returning false.

What changes do you think we should make in order to solve the problem?

Change the isChecked check to convert accountID into string. The changes in server are slower to be deployed - mentioned here this would be the way to get this working now.

What alternative solutions did you explore? (Optional)

--

[Beamanator]

Thanks @BeeMargarida - please proceed! :D

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: select all workspace invite comparison #20826

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@BeeMargarida] Determine if we should create a regression test for this bug.
• [@BeeMargarida] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@slafortune] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@Beamanator, @slafortune, @BeeMargarida Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Beamanator]

I don't think we need to do the standard checklist here - the bug was most likely due to the HUGE onyx refactor we did a few weeks back, and we expected to break things there... So I think @slafortune we can just pay this one out and close 👍

[slafortune]

Cool! And I think that there is only the reporting payout since this was worked on by Callstack - we are billed by them.

@priya-zha offer sent

[priya-zha]

Thanks. Accepted.