[HOLD for payment 2023-07-17] [$1000] OS Safari - All 6 digits visible in first digit slot when using OTP autofill

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to new.expensify.com in Safari on iOS.
2. Enter your phone number.
3. Click on the code that appears in the keyboard autofill.
4. Notice that in the first digit placeholder, all 6 digits are visible but in other slots the correct digits are visible.

Expected Result:

Each digit should be visible in its own slot.

Actual Result:

All digits are visible in the first slot, in the other slots (2nd to 6th), correct digits are visible.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.24-5
Reproducible in staging?: needs reproduction ( I don't have iphone with sim)
Reproducible in production?: needs reproduction ( I don't have iphone with sim)
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

magic_code_bug.MP4

Expensify/Expensify Issue URL:
Issue reported by: @Nikhil-Vats)
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686154610357189

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013ac63cca1c7fc022
• Upwork Job ID: 1669104099919405056
• Last Price Increase: 2023-06-21

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[KALLL]

Proposal

Please re-state the problem that we are trying to solve in this issue.

On OTP autofill all 6 digits are visible on the first field

What is the root cause of that problem?

The maxLength for each individual OTP field has been set to be Length of the OTP = 6

App/src/components/MagicCodeInput.js

Lines 315 to 321 in 93957f0

	<TextInput
	ref={(ref) => (inputRefs.current[index] = ref)}
	autoFocus={index === 0 && props.autoFocus}
	inputMode="numeric"
	textContentType="oneTimeCode"
	name={props.name}
	maxLength={props.maxLength}

App/src/components/MagicCodeInput.js

Line 68 in 93957f0

maxLength: CONST.MAGIC_CODE_LENGTH,

What changes do you think we should make in order to solve the problem?

We don't have to change the defaultProps maxLength value as it is being used for other purposes like decomposeString()
but we can change the maxLength of the TextInput :
Inside the TextInput doing maxLength={1} like

<TextInput
                                ref={(ref) => (inputRefs.current[index] = ref)}
                                autoFocus={index === 0 && props.autoFocus}
                                inputMode="numeric"
                                textContentType="oneTimeCode"
                                name={props.name}
                                maxLength={1}

will solve the problem.

What alternative solutions did you explore? (Optional)

Another possible solution is to use the onChangeText prop instead of the value prop to handle the autofill logic

[stephanieelliott]

I was able to repro this

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013ac63cca1c7fc022

[melvin-bot]

Current assignee @stephanieelliott is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)

[melvin-bot]

Triggered auto assignment to @neil-marcellini (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[stephanieelliott]

Reapplying the Bug label to get another BZ member on this while I am OOO til July 3. Thanks @conorpendergrast, I'll grab this back from you when I return!

[thesahindia]

The above proposal looks good, I will test it today.

[KALLL]

@thesahindia Hello, I was wondering if you had a chance to test my proposal for the OTP autofill issue. I would appreciate any feedback or questions you might have.

[conorpendergrast]

Waiting for @thesahindia to review now!

[thesahindia]

Sorry for the delay. I just tested this on mWeb and the solution didn't work for me.

trim.945A2E05-73A7-4D92-8B8C-68EBC4880E7F.MOV

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.38-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix OTP autofill in iOS Safari #21482

If no regressions arise, payment will be issued on 2023-07-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@thesahindia] The PR that introduced the bug has been identified. Link to the PR:
• [@thesahindia] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@thesahindia] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@thesahindia] Determine if we should create a regression test for this bug.
• [@thesahindia] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[neil-marcellini]

Bump @thesahindia

[stephanieelliott]

Sent offer to @Nikhil-Vats and @thesahindia on Upwork
@ginsuma I can't find you on Upwork, can you please propose for the job so that I can hire you? https://www.upwork.com/jobs/~01820b37e46a5ddb5e

[Nikhil-Vats]

@stephanieelliott I didn't get any offer so I have applied for the job with the reporting amount.

[thesahindia]

It was a regression from #18771. I have left a comment there. But I think we should skip the checklist because it was an extreme edge case that we couldn't have prevented.

Steps for the test case -

1. Open new dot in Safari on iOS.
2. Go to login page
3. Enter your phone number.
4. Click on the code that appears in the keyboard autofill.
5. Verify you don't see all six digits in the first digit slot

[thesahindia]

@stephanieelliott, I will request money on new dot. You can close the issue after paying others.

[ginsuma]

@stephanieelliott I submitted on Upwork.

[neil-marcellini]

Not over due, bump @stephanieelliott

[stephanieelliott]

Extended offers to @Nikhil-Vats and @ginsuma, will pay this ASAP once you accept!

[Nikhil-Vats]

Done @stephanieelliott

[neil-marcellini]

Not overdue

[stephanieelliott]

@Nikhil-Vats and @ginsuma have been paid
Regression test: https://github.com/Expensify/Expensify/issues/302570
@thesahindia will be requesting payment via newdot

[JmillsExpensify]

@stephanieelliott Can you provide amounts on that payment summary? I need this to pay @thesahindia

[stephanieelliott]

Sure, here ya go @JmillsExpensify!

Summarizing payment on this issue:

• Issue reporter: @Nikhil-Vats $250 paid via Upwork
• Contributor: @ginsuma $1000 paid via upwork
• Contributor+: @thesahindia $1000, please pay via newdot

Upwork job is here, no bonus is included on final payout

[JmillsExpensify]

$1,000 payment approved for @thesahindia based on BZ summary.