[HOLD for payment 2023-06-28] [$1000] FAB menu is displayed abracadabra page when creating a new account

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a new account
2. Validate by using magic link on another tab

Expected Result:

Abracadabra page should be displayed in the new tab and the user is logged in in the original tab.

Actual Result:

FAB menu is displayed in the abracadabra page.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.26-3

Reproducible in staging?: Yes
Reproducible in production?: No, the abracadabra page is not working in Prod.

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.3082.mp4

Expensify/Expensify Issue URL: N/A

Issue reported by: Applause - Internal team
Slack conversation: https://expensify.slack.com/archives/C9YU7BX5M/p1686591327115609?thread_ts=1686084086.585489&cid=C9YU7BX5M

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0194703ccd31bf3c81
• Upwork Job ID: 1668685660170141696
• Last Price Increase: 2023-06-13

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[dangrous]

@cristipaval I haven't been able to pin it down yet but I know you made some changes to the Abacradabra page recently, do you have any thoughts on why this might be happening?

[dangrous]

I think this might have something to do with #20216 but I'm not certain - it doesn't help that I've only been able to successfully get through the abracadabra page once on staging...

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

FAB menu is displayed on abracadabra page when creating a new account

What is the root cause of that problem?

The root cause of this issue is that after the navigation refactor, we are mounting all the screens and making them invisible. The componentDidMount method runs for all of them despite them being an inactive route. Due to this, the effect here runs, even if the user is on the abracadabra page. Once this effect runs, the popover opens up with a z-index of 9999. Since this z-index, is much greater than the z-index of the abracadabra screen, this results in the popup showing up for new users.

What changes do you think we should make in order to solve the problem?

We should render the effect defined here only if the LHN / Home screen is visible. This can be done by checking if navigation.getState().index is equal to the index of the report screen. If so, we can execute the effect defined here.

What alternative solutions did you explore? (Optional)

We can increase the z-index of the abracadabra screen such that the popover shows up behind the screen.

[melvin-bot]

Looks like something related to react-navigation may have been mentioned in this issue discussion.

As a reminder, please make sure that all proposals are not workarounds and that any and all attempt to fix the issue holistically have been made before proceeding with a solution. Proposals to change our DeprecatedCustomActions.js files should not be accepted.

Feel free to drop a note in #expensify-open-source with any questions.

[allroundexperts]

@dangrous I don't think this has to do anything with #20136.

[dangrous]

fair enough - I still can't replicate so it's making diagnosing very hard. Will look at your proposal in a sec!

[allroundexperts]

fair enough - I still can't replicate so it's making diagnosing very hard. Will look at your proposal in a sec!

You can comment these lines for easy debugging. This will cause it to show regardless of the account being new or old.

[dangrous]

Hey @isagoico - you mentioned "No, the abracadabra page is not working in Prod." - can you confirm that you're not able to ever load the abracadabra page on production? Thanks!

[mountiny]

I think the proposal from @allroundexperts sounds good, but I would confirm if this is indeed a deploy blocker and if not I would wait for SWM review of the solution

[isagoico]

you mentioned "No, the abracadabra page is not working in Prod." - can you confirm that you're not able to ever load the abracadabra page on production? Thanks!

Yes, this flow was broken on the a previous deployment, here's the bug #20136. The abracadabra page has worked on previous builds on Staging and Prod.

[dangrous]

That's very helpful, thank you!

[mollfpr]

@muttmuure Could you assign me to this issue since I got the PR review done? Thanks!

[melvin-bot]

📣 @mollfpr You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

@dangrous, @mollfpr, @allroundexperts, @muttmuure Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[dangrous]

Hm, not sure why Melvin posted that. Not overdue

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: prevent welcome message showing up on abradacabra page #20706

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mollfpr / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@mollfpr / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mollfpr / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mollfpr / @allroundexperts] Determine if we should create a regression test for this bug.
• [@mollfpr / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@muttmuure] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mollfpr]

[@mollfpr / @allroundexperts] The PR that introduced the bug has been identified. Link to the PR:

#12369

[@mollfpr / @allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

https://github.com/Expensify/App/pull/12369/files#r1246026718

[@mollfpr / @allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

The regression step should be cover this up.

[@mollfpr / @allroundexperts] Determine if we should create a regression test for this bug.

Yes!

[@mollfpr / @allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression step:

1. Open the App and create a new account
2. Validate by using a magic link on another tab
3. Verify that the welcome menu appears in the original tab while the new tab shows the Abracadabra page without the welcome menu.
4. 👍 or 👎

[muttmuure]

@allroundexperts and @mollfpr invited to apply

[muttmuure]

Offers sent

[allroundexperts]

Accepted @muttmuure!

[muttmuure]

Everyone has been paid - closing out