[HOLD for payment 2023-06-19] [$1000] Reveal message is in english if changed language to spanish

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. From Person A: Create a workspace> Invite Person B
2. From Person A: Create a new room in restricted mode
3. From Person A: Send a message on the room
4. From User B: Send a message to the same room
5. From User A: Change language to Spanish and mark the message sent by User B as spam
6. Notice that from User A ,the message was changed to Spanish but the reveal message button is still in english

Expected Result:

Reveal messages should be changed to spanish

Actual Result:

Reveal message is in english if changed language to Spanish

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.22
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

error-2023-06-01_10.19.14.mp4

Expensify/Expensify Issue URL:
Issue reported by: @priya-zha
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1685592704388239

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~010a9276f705644149
• Upwork Job ID: 1665661469359173632
• Last Price Increase: 2023-06-05

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[situchan]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Reveal message" is not localized in chat message item

What is the root cause of that problem?

There's no localization implemented here:

App/src/pages/home/report/ReportActionItem.js

Line 311 in fc30ddc

{isHidden ? 'Reveal message' : 'Hide message'}

What changes do you think we should make in order to solve the problem?

Use same localization here:

App/src/pages/home/report/ReportActionItem.js

Line 281 in fc30ddc

{isHidden ? props.translate('moderation.revealMessage') : props.translate('moderation.hideMessage')}

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~010a9276f705644149

[melvin-bot]

Current assignee @twisterdotcom is eligible for the External assigner, not assigning anyone new.

[twisterdotcom]

This is one even I could do!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[melvin-bot]

Triggered auto assignment to @Gonals (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[twisterdotcom]

@s77rt I think we can just assign @situchan right?

[the-mold]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Reveal button text is not changed to Spanish even though Spanish is the default language selected in settings.

What is the root cause of that problem?

This particular button message is hardcoded in code. Consider the line 311 in snippet:

App/src/pages/home/report/ReportActionItem.js

Lines 302 to 313 in 96adb8e

	<Button
	small
	style={[styles.mt2, styles.alignSelfStart]}
	onPress={() => setIsHidden(!isHidden)}
	>
	<Text
	style={styles.buttonSmallText}
	selectable={false}
	>
	{isHidden ? 'Reveal message' : 'Hide message'}
	</Text>
	</Button>

What changes do you think we should make in order to solve the problem?

I will substitute the hardcoded strings with the translate method like so:

{isHidden ? props.translate('moderation.revealMessage') : props.translate('moderation.hideMessage')}

Please note that I propose to change the second hard coded string "Hide message" to translate method as well.

What alternative solutions did you explore? (Optional)

NA

[s77rt]

@situchan Thanks for the proposal. Your RCA is correct and the solution looks good.

🎀 👀 🎀 C+ reviewed

cc @Gonals

[s77rt]

@twisterdotcom Yes! Let's do it 🚀

[s77rt]

@petromoldovan Thanks for the proposal. Unfortunately it's a dupe but feel free to check other issues with Help Wanted label here.

[melvin-bot]

📣 @situchan You have been assigned to this job by @twisterdotcom!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[twisterdotcom]

Just going to pull the trigger on this one for @Gonals.

[the-mold]

@petromoldovan Thanks for the proposal. Unfortunately it's a dupe but feel free to check other issues with Help Wanted label here.

@s77rt ooooops, you are right. I did not notice the other proposal. Thanks for the heads-up and the link!

[situchan]

PR is ready for review

[melvin-bot]

🎯 ⚡️ Woah @s77rt / @situchan, great job pushing this forwards! ⚡️

The pull request got merged within 2 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @situchan got assigned: 2023-06-05 12:57:27 Z
• when the PR got merged: 2023-06-07 09:15:35 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• localize reveal/hide message #20259

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[s77rt]

• The PR that introduced the bug has been identified: [No QA] Handle Moderated Messages in UI #19476
• The offending PR has been commented on: [No QA] Handle Moderated Messages in UI #19476 (comment)
• A discussion in #expensify-bugs has been started: Nothing to discuss, we have a checklist item for this kind of a bug I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
• Determine if we should create a regression test for this bug: No

[twisterdotcom]

Contracts extended. Accept them so they can be paid on time folks!

[twisterdotcom]

Paid!