[HOLD for payment 2023-08-21] [HOLD for payment 2023-08-17] [$1000] mweb - Chat - Conversation freezes when sending a large PDF file

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open the testing link staging.new.expensify.com
2. Open any chat.
3. Send la large PDF in the conversation.

Expected Result:

Verify the PDF preview is displayed and scrolling.

Actual Result:

Conversation freezes when sending a large PDF file.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.21.1

Reproducible in staging?: yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:
https://expensify.testrail.io/index.php?/tests/view/3481149

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6076001_mWeb_3105_1.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01742a99d4a9530002
• Upwork Job ID: 1666564922927919104
• Last Price Increase: 2023-06-07

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[puneetlath]

@kbecciv can you share the PDF you used?

[kbecciv]

@puneetlath Please attached

LARGE PDF FILE.pdf

[melvin-bot]

@puneetlath Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@puneetlath Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01742a99d4a9530002

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[melvin-bot]

Current assignee @puneetlath is eligible for the External assigner, not assigning anyone new.

[puneetlath]

Added external label to see what contributors think.

[rezkiy37]

Hi, I'm Michael (Mykhailo) from Callstack and I would like to work in this issue.

[melvin-bot]

📣 @rezkiy37! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[melvin-bot]

📣 @rezkiy37 You have been assigned to this job by @mountiny!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Thanks @rezkiy37, please remember to first post a proposal here for @0xmiroslav to review and discuss before you create a PR, thanks!

[puneetlath]

@0xmiroslav I'll be OOO this week, so if you need Internal help moving this forward during that time please ask in #contributor-plus. Thanks!

[rezkiy37]

Daily updates:

1. This is only a Safari issue.
2. Looks like, after the updating react-pdf to the last stable 6th version (6.2.2), fixes the issue on MacOS Safari.
3. Unfortunately, IOS Safari requires more steps to fix. IOS Safari simply cannot draw large canvas elements. The limit is set at 16.777.216 pixels.. Since the library renders pdf as canvas, it means there is a default limitation of pages. Once the limit has been exhausted it draws empty pages without any content.
4. There is a solution how to open 140+ pages on IOS Safari, we could set devicePixelRatio manually. This reduces the quality of pdf files a bit, things a little blurry. However, the files are still readable.
5. I am going to post a full proposal tomorrow.

[melvin-bot]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @rezkiy37 got assigned: 2023-06-12 12:09:01 Z
• when the PR got merged: 2023-08-10 18:17:27 UTC
• days elapsed: 43

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix freezes when previewing a large PDF file #22760
• Fix PDF blinks #24308
• User can scroll PDF by using the down/up arrow of keyboard #24363

If no regressions arise, payment will be issued on 2023-08-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.53-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix PDF blinks #24308
• User can scroll PDF by using the down/up arrow of keyboard #24363

If no regressions arise, payment will be issued on 2023-08-21. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @rezkiy37 does not require payment (Contractor)
• @0xmiroslav requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@0xmiroslav] The PR that introduced the bug has been identified. Link to the PR:
• [@0xmiroslav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@0xmiroslav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@0xmiroslav] Determine if we should create a regression test for this bug.
• [@0xmiroslav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@0xmiroslav friendly reminder on the checklist so that we can get his paid out and closed out. Thanks!

[0xmiros]

This is not a regression. If we already have pdf preview case in TestRail, it would be good to suggest testing very large PDF as well.

Btw I initially reviewed PR and @situchan continued review to the end. How we handle compensation this case?

[puneetlath]

Perhaps we can split it 50/50. Does that seem fair to you two?

[situchan]

Fair to me

[puneetlath]

@0xmiroslav @situchan sent you both offers:

https://www.upwork.com/nx/wm/offer/26515094
https://www.upwork.com/nx/wm/offer/26515111

[puneetlath]

Paid @situchan.

@0xmiroslav bump on accepting the contract.

[puneetlath]

@0xmiroslav is tracking the payment he is due separately, so I'm going to go ahead and close his one out. Thanks everyone!