Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox label is not wrapped but truncated #19567

Closed
6 tasks done
kavimuru opened this issue May 25, 2023 · 6 comments
Closed
6 tasks done

checkbox label is not wrapped but truncated #19567

kavimuru opened this issue May 25, 2023 · 6 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Navigate to Settings > Workspaces > any workspace > Connect bank account
  2. Complete Step 1
  3. On Step 2, scroll down to bottom and observe checkbox label

Expected Result:

"I confirm that this company..." text is displayed multiline and not truncated

Actual Result:

"I confirm that this company..." text is truncated in single line

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.18
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screenshot 2023-05-22 at 9 27 04 PM

Recording.749.mp4

Expensify/Expensify Issue URL:
Issue reported by: @situchan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684816657258979

View all open jobs on GitHub

@kavimuru kavimuru added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@kavimuru
Copy link
Author

Proposal by @situchan

Proposal

Please re-state the problem that we are trying to solve in this issue.

checkbox label is not wrapped but truncated

What is the root cause of that problem?

This came from #19101 where TouchableOpacity is replaced with PressableWithFeedback in CheckboxWithLabel component.
PressableWithFeedback has 2 view layers (GenericPressable, OpacityView) and flex not applied to GenericPressable

What changes do you think we should make in order to solve the problem?

pass wrapperStyle={[styles.flex1]} here

@hungvu193
Copy link
Contributor

Are you able to reproduce @kavimuru ?
It's fixed in here: #19537

@situchan
Copy link
Contributor

This one can be closed. All payments will be handled in #19482.

@luacmartins
Copy link
Contributor

Closing in favor of #19482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2
Projects
None yet
Development

No branches or pull requests

5 participants