[HOLD for payment 2023-06-19] [$1000] LHN logic for threads is wrong (inconsistent with other chats)

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat room (non-DM)
2. Thread a message in that chat

Expected Result:

The thread appears in the LHN with a preview of the message threaded, followed by the most recent message in the thread.

Actual Result:

The thread appears in the LHN with a preview of the message threaded, followed by the workspace name and room name

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.17.0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684503061244619

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01422c3862e47a029f
• Upwork Job ID: 1661857447696506880
• Last Price Increase: 2023-06-01

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[stitesExpensify]

Started looking into this. Right now we are showing the same thing for the header and the lhn which is not intended. This can be external.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01422c3862e47a029f

[melvin-bot]

Current assignee @tjferriss is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot]

Current assignee @stitesExpensify is eligible for the External assigner, not assigning anyone new.

[hoangzinh]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN logic for threads is wrong (inconsistent with other chats)

What is the root cause of that problem?

This is existing logic when show LHN for a thread coming from a chatRoom

App/src/components/LHNOptionsList/OptionRowLHN.js

Lines 83 to 84 in a479683

	// If the item is a thread within a workspace, we will show the subtitle as the second line instead of in a pill
	const alternativeText = optionItem.isThread && optionItem.subtitle ? optionItem.subtitle : optionItem.alternateText;

That means when it's a threadReport, it gonna show the report's subtitle which is combination of policy name and reportName

What changes do you think we should make in order to solve the problem?

If we want to keep it consistency with other chats. We just need to replace above line by

const alternativeText = optionItem.alternateText;

So it will alway renders the latest message for any report type

Result:

[stitesExpensify]

cc @aimane-chnaif ^

[ShogunFire]

Looks like it was wanted here #18755 , but I don't have access to the word so I don't know why. Here is the PR: #18522

[tjferriss]

@aimane-chnaif @stitesExpensify what is the next step here? What do you think of @hoangzinh proposal?

[aimane-chnaif]

I asked confirmation here - https://github.com/Expensify/App/pull/18522/files#r1212295913 to avoid any regression.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[stitesExpensify]

This is what the doc says:

LHN:

Header:

[stitesExpensify]

Makes sense to me

[melvin-bot]

📣 @hoangzinh You have been assigned to this job by @stitesExpensify!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[hoangzinh]

@aimane-chnaif @stitesExpensify PR is ready #20241. Please help me to review it. Thanks ❤️

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.26-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix Thread report doesn't show most recent message in LHN #20241

If no regressions arise, payment will be issued on 2023-06-19. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter NA internal
• Contributor that fixed the issue @hoangzinh
• Contributor+ that helped on the issue and/or PR @aimane-chnaif

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@tjferriss] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[tjferriss]

@hoangzinh @aimane-chnaif I've sent you both an offer in Upworks. You're both eligible for the 50% speed bonus.

@aimane-chnaif can you get started on the checklist?

[hoangzinh]

accepted offer. Thanks @tjferriss

[tjferriss]

Everyone is hired in Upworks. We just need to complete the checklist and pay everyone out after the regression period.

[melvin-bot]

@tjferriss, @hoangzinh, @stitesExpensify, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[tjferriss]

The payments have been sent via Upworks. @aimane-chnaif can you please complete the checklist?

[aimane-chnaif]

I'd say the original issue was intentional and the design changed for consistency. No need to point out the offending PR.

Regression Test Proposal

1. Go to any chat room and send any message
2. Thread that message
3. In thread chat, send any new message
4. Verify that selected row in LHN shows threaded message as title, the most recent message as subtitle

[melvin-bot]

@tjferriss, @hoangzinh, @stitesExpensify, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[tjferriss]

Regression test has been created https://github.com/Expensify/Expensify/issues/295396