Split Bill - Incorrect Split participants list if Spit bill among part of the group

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #18143

Action Performed:

1. Login to NewDot
2. Create a group with 5 other accounts
3. Click "+" in the group chat
4. Split any bill between part of the group, for example add 3 participants
5. Observer IOU Preview show your avatar and +3 icon
6. Click on the IOR Preview

Expected Result:

List of split bill participants should be displayed

Actual Result:

Whole group list is displayed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.12.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6048234_video_87.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[allroundexperts]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect list of participants when splitting the bill

What is the root cause of that problem?

The root cause of the issue is that for the split bill IOU action, we don't get the IOUReportID. As such, we can't use this route. We seem to be missing this case entirely in our code here. As it can be seen, if there are multiple participants (ie split bill IOU action type), we're simply redirecting the user to the list of participants of the chat report itself. While this might produce correct results for 1-1 chats, but for group chats, this causes the issue highlighted in this ticket.

What changes do you think we should make in order to solve the problem?

We can create a new route that takes the reportId and the actionId as the input. This route would render the same ReportParticipantsPage component. The ReportParticipantsPage would have to be modified such that it can get participants from reportId and actionId (action.originalMessage.participants). This modification can be done in the getAllParticipants function defined in the same component.

What alternative solutions did you explore? (Optional)

We can make the Split bill action not Pressable. I think this might cause a bad user experience and should be avoided.

[zanyrenney]

At Accountex so won't get to triaging this bug for a few days, reassigning.

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[bernhardoj]

Tapping it will open the group participants page for now.

Based on the PR details, this is expected for now.

[puneetlath]

Closing based on the discussion here: https://expensify.slack.com/archives/C01GTK53T8Q/p1684174641690159