DEV: Requested or sent money message shows default profile picture

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. change Profile picture(if it’s default Profile picture)
2. go to any chat
3. click on + icon
4. select requested or sent money option
5. request or sent any amount
6. check the profile picture in chat

Expected Result:

should not show default profile picture

Actual Result:

default profile picture appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: Dev
Reproducible in staging?: n/a
Reproducible in production?: n/a
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-06.at.12.42.16.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1683357157168249

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Prince-Mendiratta]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In this issue, we can see that when we request / send money, the avatar shown is default even when the user has a custom profile picture.

What is the root cause of that problem?

Seems to be a regression from #18143 possibly.

To show the avatars, we use the OptionsListUtils.getAvatarsForLogins function for fetching the avatar url from the user details. The getAvatarsForLogins demands two parameters, the array of participants and the personalDetails for all users. Although we pass the array of emails, we do not pass all the user's personal details. This causes the function to return the default avatar image for the users.

App/src/libs/OptionsListUtils.js

Lines 137 to 144 in d120f6a

	/**
	* Returns avatar data for a list of user logins
	*
	* @param {Array<String>} logins
	* @param {Object} personalDetails
	* @returns {Object}
	*/
	function getAvatarsForLogins(logins, personalDetails) {

What changes do you think we should make in order to solve the problem?

In order to fix this issue, we need to pass an onyx key, ONYXKEYS.PERSONAL_DETAILS to the withOnyx function. We can then modify this line and pass the props.personalDetails as the second parameter to fix this issue.

App/src/components/ReportActionItem/IOUPreview.js

Line 141 in d120f6a

const participantAvatars = OptionsListUtils.getAvatarsForLogins(participantEmails);

What alternative solutions did you explore? (Optional)

Optionally, we use could use the withCurrentUserPersonalDetails HOC for the same purpose.

Alternate 3
We could also use the onyx key ONYXKEYS.PERSONAL_DETAILS directly in OptionsListUtils but I would prefer the first 2 solutions.

[trjExpensify]

Discussion on the thread here, closing.