Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-06-30] [$250] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction #17047

Closed
roryabraham opened this issue Apr 6, 2023 · 18 comments
Closed

[HOLD for payment 2023-06-30] [$250] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction #17047

roryabraham opened this issue Apr 6, 2023 · 18 comments
Assignees
@conorpendergrast @luacmartins @robertKozik @0xmiros
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.

Comments

@roryabraham
Copy link
Contributor

roryabraham commented Apr 6, 2023 •
edited by conorpendergrast
Loading

Description

Migrate PressableWithSecondaryInteraction to use GenericPressable

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0188a33040575e26df
  • Upwork Job ID: 1666247936132612096
  • Last Price Increase: 2023-06-07
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Apr 6, 2023
@roryabraham roryabraham self-assigned this Apr 6, 2023
@MelvinBot

This comment was marked as resolved.

Sign in to view
@melvin-bot melvin-bot bot added the Weekly KSv2 label Apr 6, 2023
@roryabraham roryabraham added Monthly KSv2 and removed Weekly KSv2 labels Apr 6, 2023
@roryabraham roryabraham removed their assignment Apr 6, 2023
@roryabraham roryabraham moved this from HOLD to Todo in Accessible Pressables May 11, 2023
@roryabraham roryabraham changed the title [HOLD][Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction May 11, 2023
@melvin-bot melvin-bot bot added the Overdue label May 11, 2023
@Skalakid Skalakid mentioned this issue Jun 5, 2023
Closed
@robertKozik
Copy link
Contributor

Can you assign me to this one, please?

@Skalakid Skalakid mentioned this issue Jun 6, 2023
Closed
@muxriddinmuqimov77
Copy link

I want to work on it.

@0xmiros 0xmiros mentioned this issue Jun 6, 2023
Merged
57 tasks
@roryabraham roryabraham added the External Added to denote the issue can be worked on by a contributor label Jun 7, 2023
@melvin-bot melvin-bot bot changed the title [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction [$1000] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0188a33040575e26df

@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Monthly KSv2 Overdue labels Jun 7, 2023
@roryabraham roryabraham changed the title [$1000] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction [$250] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

Upwork job price has been updated to $250

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Jun 7, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 7, 2023

📣 @0xmiroslav You have been assigned to this job by @roryabraham!
Please apply to this job in Upwork and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@luacmartins luacmartins added the Reviewing Has a PR in review label Jun 7, 2023
@conorpendergrast
Copy link
Contributor

conorpendergrast commented Jun 9, 2023 •
edited
Loading

Sent contract to @0xmiroslav for $250 on Upwork

@conorpendergrast
Copy link
Contributor

Looks like the PR is still under review, and making progress

@conorpendergrast
Copy link
Contributor

PR review ongoing 👍

@roryabraham roryabraham moved this from Todo to In Progress in Accessible Pressables Jun 19, 2023
@conorpendergrast
Copy link
Contributor

Looks like PR was just approved by C+, and now waiting for Carlos' review!

@melvin-bot
Copy link

melvin-bot bot commented Jun 22, 2023

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

  • when @robertKozik got assigned: 2023-06-07 00:58:32 Z
  • when the PR got merged: 2023-06-22 15:26:02 UTC
  • days elapsed: 12

On to the next one 🚀

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Daily KSv2 labels Jun 23, 2023
@melvin-bot melvin-bot bot changed the title [$250] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction [HOLD for payment 2023-06-30] [$250] [Group 5][Accessible Pressable] Migrate PressableWithSecondaryInteraction Jun 23, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Jun 23, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.31-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-06-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Jun 30, 2023
@conorpendergrast
Copy link
Contributor

Ah, sorry I missed payment on Friday. I've paid @0xmiroslav via Upwork now!

@melvin-bot melvin-bot bot removed the Overdue label Jul 3, 2023
@conorpendergrast
Copy link
Contributor

All done I think. Closing!

@github-project-automation github-project-automation bot moved this from In Progress to Done in Accessible Pressables Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conorpendergrast conorpendergrast

@luacmartins luacmartins

@robertKozik robertKozik

@0xmiros 0xmiros

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor NewFeature Something to build that is a new item.
Projects
No open projects
Accessible Pressables
Status: Done
Milestone
No milestone
Development

No branches or pull requests
9 participants
@mananjadhav @conorpendergrast @slafortune @MelvinBot @luacmartins @roryabraham @robertKozik @0xmiros @muxriddinmuqimov77