Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOLD for payment 2023-10-10] [$250] Migrate PopoverReportActionContextMenu.js to function component #16260

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 27 comments
Closed
1 task

[HOLD for payment 2023-10-10] [$250] Migrate PopoverReportActionContextMenu.js to function component #16260

marcaaron opened this issue Mar 20, 2023 · 27 comments
Assignees
@garrettmknight @OlimpiaZurek @s-alves10
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Milestone
React Class Compo...

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023 •
edited by melvin-bot bot
Loading

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~010643b60479e58d59
  • Upwork Job ID: 1698636823299244032
  • Last Price Increase: 2023-09-04
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate PopoverReportActionContextMenu.js to function component [HOLD][$250] Migrate PopoverReportActionContextMenu.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@muxriddinmuqimov77
Copy link

I'd like to work on this issue

@s-alves10
Copy link
Contributor

I'd love to work on this.

@vdem0115
Copy link

vdem0115 commented Jul 5, 2023

I would like to work on this.

@multijump
Copy link
Contributor

I'd like to work on this issue.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this?

@dhairyasenjaliya
Copy link
Contributor

@rayane-djouah there is no benefit to spamming comments like this, add a comment on the un-hold issue only

@to-ai
Copy link

to-ai commented Jul 11, 2023

I am able to work on this task.

@ghost
Copy link

ghost commented Jul 14, 2023

Dibs

@code0406
Copy link
Contributor

I like to work on this task.

@OlimpiaZurek
Copy link
Contributor

OlimpiaZurek commented Sep 1, 2023 •
edited
Loading

@marcaaron Hi, I'm Olimpia from Callstack - expert contributor group - I would like to take a look at this issue.

@mountiny mountiny changed the title [HOLD][$250] Migrate PopoverReportActionContextMenu.js to function component [$250] Migrate PopoverReportActionContextMenu.js to function component Sep 4, 2023
@mountiny mountiny added the Internal Requires API changes or must be handled by Expensify staff label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Job added to Upwork: https://www.upwork.com/jobs/~010643b60479e58d59

@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

@mountiny
Copy link
Contributor

mountiny commented Sep 4, 2023

Go ahead, note the PR will be on hold for the merge freeze

@OlimpiaZurek OlimpiaZurek mentioned this issue Sep 12, 2023
Merged
59 tasks
@OlimpiaZurek
Copy link
Contributor

@marcaaron PR is ready for code review: #27221

@mountiny mountiny assigned s-alves10 and unassigned Ollyws Oct 1, 2023
@mountiny mountiny added Bug Something is broken. Auto assigns a BugZero manager. and removed Internal Requires API changes or must be handled by Expensify staff labels Oct 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@mountiny mountiny removed the Bug Something is broken. Auto assigns a BugZero manager. label Oct 1, 2023
@melvin-bot melvin-bot bot added the Daily KSv2 label Oct 1, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

mountiny commented Oct 1, 2023 •
edited
Loading

There was a regression from this PR and I believe @s-alves10 was the C+ on the PR so we need to half the payment here

@melvin-bot melvin-bot bot added the Overdue label Oct 3, 2023
@garrettmknight garrettmknight added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 3, 2023
@garrettmknight garrettmknight changed the title [$250] Migrate PopoverReportActionContextMenu.js to function component [HOLD for payment 2023-10-10] [$250] Migrate PopoverReportActionContextMenu.js to function component Oct 3, 2023
@garrettmknight
Copy link
Contributor

Looks like the PR is on prod - adding the Awaiting Payment hold.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 3, 2023
@garrettmknight
Copy link
Contributor

Still holding for payment

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 6, 2023
@garrettmknight
Copy link
Contributor

Holding for payment, will pay tomorrow.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Overdue Daily KSv2 labels Oct 9, 2023
@garrettmknight
Copy link
Contributor

Summary of payment for this issue:

Upwork Job: https://www.upwork.com/en-gb/nx/wm/offer/27148323

@garrettmknight
Copy link
Contributor

@s-alves10 will you accept the proposal so I can pay out for this one? Thanks!

@s-alves10
Copy link
Contributor

s-alves10 commented Oct 11, 2023 •
edited
Loading

@garrettmknight

I was not the C+ for this issue. I mentioned about the root cause of the regression.
#27221 (comment)

Thanks

cc @mountiny

@mountiny
Copy link
Contributor

Ok there was no C+ so I think we can close this issue as there i nobody to pay as Olimpia is from Callstack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garrettmknight garrettmknight

@OlimpiaZurek OlimpiaZurek

@s-alves10 s-alves10

Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement.
Projects
None yet
Milestone
React Class Component Migration
Development

No branches or pull requests