Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-10] [$250] Migrate withLocalize.js to function component #16222

Closed
1 task
marcaaron opened this issue Mar 20, 2023 · 25 comments
Closed
1 task
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.

Comments

@marcaaron
Copy link
Contributor

marcaaron commented Mar 20, 2023

Class Component Migration

Filenames

Task

  • We currently have some class components in our codebase that we would like to refactor to a function component.
  • Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
  • If you need additional guidance, please ask in #expensify-open-source
  • Test for any regressions and verify that there are no breaking changes
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0153c9704e360a9cc8
  • Upwork Job ID: 1699126771485630464
  • Last Price Increase: 2023-09-05
@marcaaron marcaaron added Engineering Improvement Item broken or needs improvement. labels Mar 20, 2023
@melvin-bot melvin-bot bot locked and limited conversation to collaborators Mar 20, 2023
@Expensify Expensify unlocked this conversation Mar 21, 2023
@marcaaron marcaaron changed the title [HOLD] Migrate withLocalize.js to function component [HOLD][$250] Migrate withLocalize.js to function component Apr 13, 2023
@MelvinBot
Copy link

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@marcaaron
Copy link
Contributor Author

Heads up! The pricing for this issue has been adjusted based on the scope of the work and the fact that no complex bug investigations or proposal are required.

@s-alves10
Copy link
Contributor

I'd love to work on this.

@dayana7204
Copy link
Contributor

I am ready to work on this ticket. :)

@vdem0115
Copy link

vdem0115 commented Jul 7, 2023

I would like to work on this issue.

@olexyt
Copy link
Contributor

olexyt commented Jul 7, 2023

I can work on this issue.

@rayane-djouah
Copy link
Contributor

Can I work on this?

@pradeepmdk
Copy link
Contributor

i will work on this

@MaciejSWM
Copy link
Contributor

Hey! I’m from Software Mansion, an expert agency, and I’d like to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 labels Aug 29, 2023
@marcaaron marcaaron added the Internal Requires API changes or must be handled by Expensify staff label Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0153c9704e360a9cc8

@marcaaron marcaaron self-assigned this Sep 5, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 5, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @Ollyws (Internal)

@marcaaron marcaaron changed the title [HOLD][$250] Migrate withLocalize.js to function component [$250] Migrate withLocalize.js to function component Sep 5, 2023
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Sep 29, 2023
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 3, 2023
@melvin-bot melvin-bot bot changed the title [$250] Migrate withLocalize.js to function component [HOLD for payment 2023-10-10] [$250] Migrate withLocalize.js to function component Oct 3, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 3, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 3, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 10, 2023
@abdulrahuman5196
Copy link
Contributor

No checklist for this issue

@melvin-bot melvin-bot bot added the Overdue label Oct 13, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

@abdulrahuman5196, @roryabraham, @MaciejSWM Eep! 4 days overdue now. Issues have feelings too...

@abdulrahuman5196
Copy link
Contributor

@roryabraham It seems there is no BZ assigned here. Could you kindly add one for payment processing?

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@roryabraham roryabraham added the NewFeature Something to build that is a new item. label Oct 18, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 18, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 Overdue labels Oct 18, 2023
@roryabraham
Copy link
Contributor

@kadiealexander tagging you in for payment processing

@roryabraham roryabraham added Daily KSv2 and removed Weekly KSv2 labels Oct 18, 2023
@kadiealexander
Copy link
Contributor

kadiealexander commented Oct 19, 2023

@kadiealexander
Copy link
Contributor

Payouts due:

Eligible for 50% #urgency bonus? No

Upwork job is here.

@kadiealexander
Copy link
Contributor

All paid @roryabraham

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

@abdulrahuman5196, @roryabraham, @kadiealexander, @MaciejSWM Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@roryabraham
Copy link
Contributor

Cool cool, this is done

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests