[$1000] Reimburse- Error message is displayed after quick input of Rate and Unit

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Log with any account
3. Select any workspace
4. Select tab Reimburse expenses then Track distance
5. Quickly enter the numbers so that 000 does not appear in succession. Immediately select Unit

Expected Result:

No error message is displayed after quick input of Rate and Unit

Actual Result:

Error message is displayed after quick input of Rate and Unit

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.85.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5979144_Recording__2109.mp4

Bug5979144_ios_15.03.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~011e6f8ab17a2387c5
• Upwork Job ID: 1640484579872690176
• Last Price Increase: 2023-04-11

[MelvinBot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Triggered auto assignment to @mateocole (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[sonialiap]

Going OOO until the 25th, reassigning

[MelvinBot]

@mateocole Whoops! This issue is 2 days overdue. Let's get this updated quick!

[mateocole]

This looks like a bug, going to have an engineer confirm this is good to mark as external

[MelvinBot]

Triggered auto assignment to @joelbettner (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[joelbettner]

@mateocole @kbecciv this is definitely a bug and should be fixed. That entire selector has issues. It tries to add 3 decimal places automatically to the end of the rate before I'm done typing what I want the rate to be. I think the scope of fixing this should be fixing the entire track distance selector and not just the error that we get when switching units.

[mateocole]

Okay thanks @joelbettner, going to mark as external

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~011e6f8ab17a2387c5

[MelvinBot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[joelbettner]

It looks like we are getting close to having the above mentioned PR get merged.

[michaelhaxhiu]

#18454 (comment)

@ShogunFire will merge this to main soon. Let's figure out that bug that @eVoloshchak discovered though because we don't want a regression.

[joelbettner]

Discussion happening in the PR. Not overdue.

[melvin-bot]

@shawnborton, @eVoloshchak, @michaelhaxhiu, @joelbettner, @ShogunFire Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[joelbettner]

The PR for this has been merged. @eVoloshchak @michaelhaxhiu what are our next steps from here to officially close this issue?

[eVoloshchak]

@eVoloshchak @michaelhaxhiu what are our next steps from here to officially close this issue?

@joelbettner, there were a couple of regressions found, we're going to fix those in the follow-up PR(s).
After that, we need to wait for this to be deployed to production, wait 7 days and if there are no regressions - complete the BZ checklist and close this one out

[trjExpensify]

Should the reviewing label be on this issue, a PR has been in review and deployed?

[ShogunFire]

@trjExpensify The PR has been deployed in prod yes, the PRs to fix the regressions are also deployed

[ShogunFire]

Hello @trjExpensify I am not sure how it works yet but since this has been in production for 5 days, doesn't it mean the payment would be in 2 days ? Usually the title becomes Hold For Payment that's why I am asking. Thanks

[trjExpensify]

Yeah, 7 days from hitting prod and the issue title should have updated. @michaelhaxhiu is managing this issue, and can confirm on the timeline though!

[ShogunFire]

@michaelhaxhiu Can you check that ? I believe the payment should have been done 2 days ago, Thanks

[eVoloshchak]

Yeah, the latest PR with regression fixes for this was merged on May 30th, so the payment date should be Jun 7th

This was merged more than 9 business days after the assignment
There were 3 regressions:
$ #19703
$ #19702
$ #19704

As for the BZ checklist, we've ended up creating a new page, so this looks more like a feature request. Since we're using a single endpoint for rate and unit, the original bug is impossible now

[ShogunFire]

It looks like @michaelhaxhiu is not here. Can someone else do the the paiement 🙏 ?

[eVoloshchak]

@ShogunFire, apologies for the delay
Per CONTRIBUTING.md

If you have not received payment after 8 days of the PR being deployed to production and there being no regressions, please email [email protected] referencing the GH issue and your GH handle.

Could you do that please? I think that's the most streamlined way of doing this, if you won't receive a response - ping me here

[michaelhaxhiu]

Just catching up - sorry I lost track of this because our automation didn't update the GH title with the payment due date.

It sounds like the solution is merged to production and any associated regressions are taken care of? I will review things now to ensure this is true.

[michaelhaxhiu]

No need to email [email protected], I'm looking!

[michaelhaxhiu]

Alright after confirming some things...

C+ payment (3x regression) = $125
C payment = $1000

[michaelhaxhiu]

Invited you both to the (new) upwork job here - https://www.upwork.com/jobs/~01d14e2966b01f915e

[michaelhaxhiu]

paid.