[PAID OUT] [$1000] Workspace’s avatar turns into placeholder for a second after user changes workspace in offline mode and goes online.

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Login with any account.
2. Go to any workspace that doesn’t have the avatar
3. Turn off the internet
4. Try to change the avatar
5. Press Back
6. Turn on the internet connection.
7. Notice that workspace’s avatar turns into placeholder for a while after fully charged to new one.

Expected Result:

Workspace’s avatar should change correctly after user goes from offline to online.

Actual Result:

workspace’s avatar turns into placeholder for a while after fully charged to new one.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.2.78-0
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

RPReplay_Final1677775856.MP4

FOHA8070.mp4

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1677776557167119

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0161188cca3cbe0452
• Upwork Job ID: 1633773256380624896
• Last Price Increase: 2023-04-05

[MelvinBot]

Triggered auto assignment to @NicMendonca (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[MelvinBot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[zanyrenney]

Hi! reassigning this as Nicole OOO.

[MelvinBot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

woohoo hey me!

[zanyrenney]

I can't reproduce this one on my side.

[zanyrenney]

I can't reproduce this so need to try and see if anyone else can. @NicMendonca was going to take a look too!

[MelvinBot]

Job added to Upwork: https://www.upwork.com/jobs/~0161188cca3cbe0452

[MelvinBot]

Current assignee @zanyrenney is eligible for the External assigner, not assigning anyone new.

[MelvinBot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[zanyrenney]

Oh nice, those changes are great. Thanks @MonilBhavsar

[MonilBhavsar]

I updated the steps in the new issue as github messed with the numbering 😂

Screen.Recording.2023-04-19.at.6.33.28.PM.mov

[zanyrenney]

Completed, and regression test requested.

[marcaaron]

Sorry everyone, we are going to need to find a new solution to this issue as I am reverting the code that we shipped to fix this issue. I commented last month here that the solution was not really appropriate, but no action was taken on that and it ended up blocking a critical performance improvement so now I'm reverting it.

The PR where I am reverting it is here.

Sorry about this and thanks for your patience and understanding.

[zanyrenney]

Hey @marcaaron can you clarify what the steps needed here then are? Should we be recreating another Upwork job and looking for alternative solutions to that? Thanks!

[marcaaron]

I am not sure what we want to do here. But the original solution is ❌

What makes the most sense to me is to keep this issue open so we can take another crack at solving it at it's "root cause".

I'd probably try to start some discussion internally before creating another Upwork job to make sure it's something we want to field proposals for. I can't say for sure - but some more care and thought needs to go into fixing this bug.

Maybe @MonilBhavsar can lead this up? IIRC we previously discussed this PR in Slack.

[zanyrenney]

Thanks @marcaaron that's super helpful. I appreciate the additional context.

[zanyrenney]

@MonilBhavsar do you have capacity to lead up the discussion about if we want to fix this?

[MonilBhavsar]

Yes, can we please confirm the issue is still reproducible. Would be good to confirm.

[zanyrenney]

Hey, I am heading OOO shortly, so assigning another bug0 team member to help watch over this issue whilst I am OOO. The latest is from @MonilBhavsar above, where we are wanting to check reproducibility please!

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[zanyrenney]

hey gal friend, please can you watch over this one? No payouts required ( I have done them all already) just to check the reproducibility. @maddylewis

[maddylewis]

i will try to repro today and follow up

[maddylewis]

i cannot reproduce this or the result i got looks like expected behavior. the icon is slightly greyed out for a short time while the internet reconnects -

2023-06-26_14-37-34.mp4

[marcaaron]

Sorry - this is my bad. It will be reproducible once we rollback the code. But is still in reviews so that's why it is not reproducible.

Let's maybe close this and I will make a note to either reopen it or create a new issue and link back to this one so we can restart the process. We didn't quite get it right this time - but that's OK - we will try again! 💪