[HOLD for payment 2023-02-23] Web - Chat - Overlapping of two modal windows

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL
2. Login with any account
3. Go to any chat
4. Click on "+" (don't choose anything)
5. Press the combination "CTRL+I" on the keyboard

Expected Result:

Modal windows NOT overlap

Actual Result:

Modal windows overlap

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Windows / Chrome

Version Number: 1.2.45.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01e53ae5747e85f4a8
• Upwork Job ID: 1608883645591175168
• Last Price Increase: 2022-12-30

[davidcardoza]

i am heading out of the office. I am going to reassign this out to make sure the issue is being evaluated properly.

[pecanoro]

@laurenreidexpensify I think we have two options here:

• If we are pressing the shortcut after the menu is open, we could close it and open the shortcut modal.
• Open the shortcut modal on top of the menu that is already open since it was the second one that was triggered.

[pecanoro]

Bringing this discussion to slack! https://expensify.slack.com/archives/C01GTK53T8Q/p1672748440121389

[melvin-bot]

@pecanoro, @laurenreidexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@pecanoro, @laurenreidexpensify Eep! 4 days overdue now. Issues have feelings too...

[laurenreidexpensify]

@pecanoro are we held on review on either of those linked PRs?

[laurenreidexpensify]

@pecanoro bump ^^

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[laurenreidexpensify]

@MitchExpensify reassigning while I am OOO - please continue to work with @pecanoro on this one.

@pecanoro bump pls on next steps. Thanks

[MitchExpensify]

Just to be sure, it looks like @mananjadhav didn't end up reviewing the internal PR and that @Beamanator did. So no contributor payment is due here, right?

[pecanoro]

No, no, that was a different PR for something else that didn't fix the bug here. @mananjadhav is reviewing the PR for this bug!

[pecanoro]

PR is here: #13956

[MitchExpensify]

Ok awesome! I had this Upwork Job created and wanted to be sure. I've invited you to it @mananjadhav !

[mananjadhav]

@MitchExpensify while I accepted the offer, the amount on the offer was 250$, instead of the default 1000$ for the internal review.

[MitchExpensify]

Thanks for the catch @mananjadhav, I've added a note to the Upwork job and will be sure to issue the payment in full!

[MelvinBot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[MelvinBot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.72-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Close all popovers when Keyboard shortcut modal is displayed #13956

If no regressions arise, payment will be issued on 2023-02-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[MelvinBot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav / @pecanoro] The PR that introduced the bug has been identified. Link to the PR: Not a regression, was a limitation of modals in React Native.
• [@mananjadhav / @pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Not a regression, was a limitation of modals in React Native.
• [@mananjadhav / @pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• [@mananjadhav] Propose regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: Not a regression

[situchan]

I found regression from #13956 which fixes this issue.
Dev console error shows when press Cmd+I while any popover is open

Root cause:
It's bad practice to call function directly in render():

App/src/components/Popover/index.js

Lines 26 to 32 in a5b9c9b

	const Popover = (props) => {
	if (props.isShortcutsModalOpen && props.isVisible) {
	// There are modals that can show up on top of these pop-overs, for example, the keyboard shortcut menu,
	// if that happens, close the pop-over as if we were clicking outside.
	props.onClose();
	return null;
	}

Solution:
call onClose() only when isShortcutsModalOpen is updated.
Since this is function component, useEffect() can be used, but I think it's better to move this logic to PopoverMenu componentDidUpdate

[pecanoro]

That's funny because I used to have it in the componentDidUpdate and changed it back 😄 Either way, the issue you link it's going to refactor the whole thing so I don't think we need to fix it right now since it's not breaking anything in particular.

[situchan]

That's funny because I used to have it in the componentDidUpdate and changed it back 😄 Either way, the issue you link it's going to refactor the whole thing so I don't think we need to fix it right now since it's not breaking anything in particular.

Oh, any reason you decided to revert back? Just to avoid using useEffect?

[pecanoro]

No reason at all, to simplify the code after @mananjadhav suggestion here.

[mananjadhav]

@pecanoro @MitchExpensify Are we good to use the Testing steps from the PR for regression test proposal? I think they're straight forward.

1. Login with any account
2. Go to any chat
3. Click on "+" (don't choose anything)
4. Press the combination "CTRL+I" on the keyboard
5. It should close the + Action menu popup
6. Background should be disabled and modal should show on top of everything
7. Repeat the process in different parts of the app and make sure the behavior is consistent

Do we agree 👍 or 👎

Also I am not sure how do I link the PR? This didn't work since the time we've added the Popovers and KeyboardShortcutsModal .

[pecanoro]

Yeah, it's not a regression, it has never worked since it was a limitation of modals as the solution here was actually closing whatever is already open because modals don't support more than one in a efficient way.

[mananjadhav]

Thanks for the comment.

@MitchExpensify quick follow up on the payment here.

[MitchExpensify]

Thanks @mananjadhav ! I was OOO on Friday, paying now!

[MitchExpensify]

Done!

[mananjadhav]

Thanks @MitchExpensify