Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sending messages in quick sequence ends up in reshuffling the messages #13250

Closed
JmillsExpensify opened this issue Dec 1, 2022 · 47 comments
Closed
Assignees
Labels
Monthly KSv2 NewFeature Something to build that is a new item.

Comments

@JmillsExpensify
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Log into any account
  2. Send several short messages quickly, one after the other other

Expected Result:

The messages are shown in that order and they do not shuffle

Actual Result:

The messages are shuffling around and eventually settle in the correct order but it takes a while.

Workaround:

None, besides sending messages more slowly

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.2.34-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Video
Expensify/Expensify Issue URL:
Issue reported by: @vitHoracek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669910218865539

View all open jobs on GitHub

@JmillsExpensify JmillsExpensify added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Dec 1, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 1, 2022

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@JmillsExpensify
Copy link
Author

Keeping as this is part of the tracking issue for sequence numbers.

@melvin-bot
Copy link

melvin-bot bot commented Dec 5, 2022

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@JmillsExpensify
Copy link
Author

Still on hold for sequence numbers, which is making great progress over the last week.

@melvin-bot
Copy link

melvin-bot bot commented Dec 9, 2022

@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@JmillsExpensify JmillsExpensify added Weekly KSv2 and removed Daily KSv2 labels Dec 12, 2022
@melvin-bot melvin-bot bot removed the Overdue label Dec 12, 2022
@JmillsExpensify
Copy link
Author

Still on hold for sequence numbers. Also removed the daily label given the hold.

@JmillsExpensify
Copy link
Author

Still held on sequence numbers.

@melvin-bot melvin-bot bot added the Overdue label Dec 27, 2022
@JmillsExpensify JmillsExpensify added Monthly KSv2 and removed Weekly KSv2 labels Dec 27, 2022
@melvin-bot melvin-bot bot removed the Overdue label Dec 27, 2022
@JmillsExpensify
Copy link
Author

Switched our the weekly for monthly given that we're still in the midst of implementation, and addressing any outstanding bugs will come very last.

@JmillsExpensify JmillsExpensify changed the title [HOLD #227234] Sending messages in quick sequence ends up in reshuffling the messages [HOLD Expensify #227234] Sending messages in quick sequence ends up in reshuffling the messages Dec 27, 2022
@JmillsExpensify
Copy link
Author

Still on hold for sequence numbers.

@roryabraham
Copy link
Contributor

roryabraham commented Jan 27, 2023

Another manifestation of this bug happens when you send an IOU request w/ a memo to someone you've never chatted with.

You're landed in the chat, and then all the actions (including the created action) "cycle through, until eventually the chat ends up in the right state.

I feel strongly that this is something we'll want to fix, but we need to be super thorough and careful with predesign to establish an effective, hard-to-break pattern for "batching offline requests"

@JmillsExpensify
Copy link
Author

Glad you bumped this. I have on most list to go through all the SN bugs, though at the very least, since this is happening and SN is done let's take it off hold.

@JmillsExpensify JmillsExpensify changed the title [HOLD Expensify #227234] Sending messages in quick sequence ends up in reshuffling the messages Sending messages in quick sequence ends up in reshuffling the messages Jan 27, 2023
@JmillsExpensify JmillsExpensify added Weekly KSv2 and removed Monthly KSv2 labels Jan 27, 2023
@JmillsExpensify
Copy link
Author

Cool, this is definitely still happening.

Screenshot 2023-02-02 at 09 07 17

@JmillsExpensify
Copy link
Author

I haven't been able to reproduce it in quite some time either – though I saw it most commonly on shaky connections.

@melvin-bot melvin-bot bot removed the Overdue label Apr 12, 2023
@roryabraham
Copy link
Contributor

Going to actually just put this on HOLD for #12775

@roryabraham roryabraham changed the title Sending messages in quick sequence ends up in reshuffling the messages [HOLD] Sending messages in quick sequence ends up in reshuffling the messages Apr 12, 2023
@roryabraham roryabraham added Weekly KSv2 and removed Daily KSv2 labels Apr 12, 2023
@JmillsExpensify
Copy link
Author

Great call, that sound good.

@quinthar
Copy link
Contributor

I'm not quite understanding how this is a replay effect thing. The issue I'm experiencing on this is on slow connections, chatting back and forth with someone, and my message the millisecond I hit the enter button appears above the most recent message I received. -- and then maybe 300 milliseconds later, when it gets a response from the server, it shifts into the correct location as the most recent message.

This has nothing to do with replaying anything, there is no offline component. I am fully online the entire time, just with the slow connection.

@JmillsExpensify
Copy link
Author

I am fully online the entire time, just with the slow connection.

I was never offline when testing this flow, just a slow connection.

@roryabraham
Copy link
Contributor

The issue I'm experiencing on this is on slow connections, chatting back and forth with someone, and my message the millisecond I hit the enter button appears above the most recent message I received. -- and then maybe 300 milliseconds later, when it gets a response from the server, it shifts into the correct location as the most recent message

Oh, this is a different issue I haven't experienced before. Nonetheless, I can fix it with the same solution I was going to use to fix this issue before I put this on HOLD for the "replay effect" solution. Namely – just ensure that optimistic actions always appear at the end of a chat.

@melvin-bot melvin-bot bot added the Reviewing Has a PR in review label Apr 23, 2023
@neil-marcellini neil-marcellini changed the title [HOLD] Sending messages in quick sequence ends up in reshuffling the messages Sending messages in quick sequence ends up in reshuffling the messages May 16, 2023
@neil-marcellini
Copy link
Contributor

Off hold for the replay effect

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels May 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 16, 2023

This issue has not been updated in over 15 days. @JmillsExpensify, @roryabraham eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@roryabraham
Copy link
Contributor

This has slipped through the cracks because it had the reviewing label before the PR was actually ready. Making it a weekly again.

@roryabraham roryabraham added Weekly KSv2 Monthly KSv2 and removed Monthly KSv2 Reviewing Has a PR in review Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jun 9, 2023
@melvin-bot melvin-bot bot added the Overdue label Jul 10, 2023
@roryabraham
Copy link
Contributor

No update

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Aug 11, 2023
@JmillsExpensify
Copy link
Author

I haven't seen this in a super long time. I'm going to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monthly KSv2 NewFeature Something to build that is a new item.
Projects
None yet
Development

No branches or pull requests

8 participants