-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sending messages in quick sequence ends up in reshuffling the messages #13250
Comments
Triggered auto assignment to @joekaufmanexpensify ( |
Keeping as this is part of the tracking issue for sequence numbers. |
@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Still on hold for sequence numbers, which is making great progress over the last week. |
@JmillsExpensify 6 days overdue. This is scarier than being forced to listen to Vogon poetry! |
Still on hold for sequence numbers. Also removed the daily label given the hold. |
Still held on sequence numbers. |
Switched our the weekly for monthly given that we're still in the midst of implementation, and addressing any outstanding bugs will come very last. |
Still on hold for sequence numbers. |
Another manifestation of this bug happens when you send an IOU request w/ a memo to someone you've never chatted with. You're landed in the chat, and then all the actions (including the created action) "cycle through, until eventually the chat ends up in the right state. I feel strongly that this is something we'll want to fix, but we need to be super thorough and careful with predesign to establish an effective, hard-to-break pattern for "batching offline requests" |
Glad you bumped this. I have on most list to go through all the SN bugs, though at the very least, since this is happening and SN is done let's take it off hold. |
I haven't been able to reproduce it in quite some time either – though I saw it most commonly on shaky connections. |
Going to actually just put this on HOLD for #12775 |
Great call, that sound good. |
I'm not quite understanding how this is a replay effect thing. The issue I'm experiencing on this is on slow connections, chatting back and forth with someone, and my message the millisecond I hit the enter button appears above the most recent message I received. -- and then maybe 300 milliseconds later, when it gets a response from the server, it shifts into the correct location as the most recent message. This has nothing to do with replaying anything, there is no offline component. I am fully online the entire time, just with the slow connection. |
I was never offline when testing this flow, just a slow connection. |
Oh, this is a different issue I haven't experienced before. Nonetheless, I can fix it with the same solution I was going to use to fix this issue before I put this on HOLD for the "replay effect" solution. Namely – just ensure that optimistic actions always appear at the end of a chat. |
Off hold for the replay effect |
This issue has not been updated in over 15 days. @JmillsExpensify, @roryabraham eroding to Monthly issue. P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do! |
This has slipped through the cracks because it had the reviewing label before the PR was actually ready. Making it a weekly again. |
No update |
I haven't seen this in a super long time. I'm going to close. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The messages are shown in that order and they do not shuffle
Actual Result:
The messages are shuffling around and eventually settle in the correct order but it takes a while.
Workaround:
None, besides sending messages more slowly
Platform:
Where is this issue occurring?
Version Number: v1.2.34-1
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Video
Expensify/Expensify Issue URL:
Issue reported by: @vitHoracek
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1669910218865539
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: