Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[N7 Account Settings] Hook up new Display name, Pronouns and Timezone pages to Profile page #12952

Closed
cristipaval opened this issue Nov 23, 2022 · 16 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review

Comments

@cristipaval
Copy link
Contributor

cristipaval commented Nov 23, 2022

Tracking issue: https://github.com/Expensify/Expensify/issues/182122

Detailed section of doc here: https://docs.google.com/document/d/17akqrbC-w8FqEoDLvcLmrX6iw4uaVrT_xlwAl-IhEzE/edit#heading=h.jl7alj505ji8

Note: The rest of the new pages are on hold. They are covered by this issue when the hold is removed.

This is part of WAQ project because we want to Align on how list selection works across platforms

@cristipaval
Copy link
Contributor Author

I'm on it. Aiming to open a PR today

@melvin-bot melvin-bot bot removed the Overdue label Nov 28, 2022
@cristipaval
Copy link
Contributor Author

This is held on New timezone pages PR

@melvin-bot melvin-bot bot added the Overdue label Dec 5, 2022
@cristipaval
Copy link
Contributor Author

Going to open a PR today.

@melvin-bot melvin-bot bot removed the Overdue label Dec 5, 2022
@cristipaval cristipaval added the Reviewing Has a PR in review label Dec 7, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 14, 2022

@cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!

@cristipaval
Copy link
Contributor Author

@MelvinBot, please pay more attention on what you have to do.

@cristipaval cristipaval added the Bug Something is broken. Auto assigns a BugZero manager. label Dec 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Dec 21, 2022

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@cristipaval
Copy link
Contributor Author

Hey @slafortune! The PR for this issue was merged today. I added the Bug label just to make sure that the C+ will get paid for the review.

@melvin-bot
Copy link

melvin-bot bot commented Dec 28, 2022

@slafortune, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Dec 30, 2022

@slafortune, @cristipaval Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot
Copy link

melvin-bot bot commented Jan 3, 2023

@slafortune, @cristipaval 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

@slafortune
Copy link
Contributor

@cristipaval Thanks for doing that! Just want to make sure I have this right - today I can pay Sobit $1000?

@cristipaval
Copy link
Contributor Author

I have a question here related to the payment for the PR. I'll keep you posted.

@cristipaval
Copy link
Contributor Author

Hey @slafortune ! Looks like PR review payment should be docked 50%.

@cristipaval
Copy link
Contributor Author

@slafortune Feel free to close this issue when the payment is done.

@slafortune
Copy link
Contributor

Created job and invited Sobit to it - #13290

@slafortune
Copy link
Contributor

Paid!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants