Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Chat - "You appear to be offline" message isn't showing if you navigate to different chats. #12946

Closed
kbecciv opened this issue Nov 22, 2022 · 5 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@kbecciv
Copy link

kbecciv commented Nov 22, 2022

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #12877

Action Performed:

  1. Go to staging.new.expensify.com
  2. Turn off the internet connection
  3. Navigate to different chats

Expected Result:

"You appear to be offline" message is showing if you navigate to different chats.

Actual Result:

"You appear to be offline" message isn't showing if you navigate to different chats.

Workaround:

Unknow

Platform:

Where is this issue occurring?

  • Web

Version Number: 1.2.30.0

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
image (2)

12877.Web.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 22, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 22, 2022

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@luacmartins luacmartins self-assigned this Nov 23, 2022
@luacmartins
Copy link
Contributor

Gonna assign myself to this one since I came back from ooo and I'm looking for WAQ issues to work on.

@luacmartins
Copy link
Contributor

This is the expected behavior as we hide the compose box and display the loading skeleton for chats that have no messages loaded. Closing.

@osama256
Copy link
Contributor

osama256 commented Dec 1, 2022

Are you looking for something like this?

offline.label.mov

@luacmartins
Copy link
Contributor

I'm not sure that we need to fix anything here as we are intentionally hiding the "You are offline" indicator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

4 participants