Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect name being displayed for Chat Rooms #12883

Closed
Gonals opened this issue Nov 21, 2022 · 19 comments
Closed

Incorrect name being displayed for Chat Rooms #12883

Gonals opened this issue Nov 21, 2022 · 19 comments
Assignees
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff

Comments

@Gonals
Copy link
Contributor

Gonals commented Nov 21, 2022

Action Performed:

  1. If needed, create a workspace
  2. Create a workspace room
  3. Navigate to the room in the LHN

Expected Result:

The name of the room should be displayed correctly

Actual Result:

  • The name of the room is displayed as Chat Report for a second before changing to the correct one.
  • In the LHN, it remains displaying incorrectly until you leave the room.
  • If offline, the incorrect name displays permanently

Workaround:

Not needed

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

**Version Number: 1.2.29-6
**Reproducible in staging?: YES
**Reproducible in production?: YES

View all open jobs on GitHub

@Gonals Gonals added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Nov 21, 2022
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2022

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@Gonals Gonals added Engineering Improvement Item broken or needs improvement. labels Nov 21, 2022
@Gonals Gonals self-assigned this Nov 21, 2022
@varshamb
Copy link
Contributor

Reported on Slack

https://expensify.slack.com/archives/C049HHMV9SM/p1668485291380349

@lschurr
Copy link
Contributor

lschurr commented Nov 21, 2022

Can this stay internal since you've already put up a fix @Gonals?

@JmillsExpensify
Copy link

JmillsExpensify commented Nov 21, 2022

Same root cause as the original bug report here: https://expensify.slack.com/archives/C01GTK53T8Q/p1668041691611749. First reported by @neil-marcellini.

@lschurr
Copy link
Contributor

lschurr commented Nov 21, 2022

Do we need this to stay open or it's being fixed elsewhere?

@Gonals Gonals added the Internal Requires API changes or must be handled by Expensify staff label Nov 22, 2022
@Gonals
Copy link
Contributor Author

Gonals commented Nov 22, 2022

Can this stay internal since you've already put up a fix @Gonals?

Yep!

@Gonals
Copy link
Contributor Author

Gonals commented Nov 22, 2022

Do we need this to stay open or it's being fixed elsewhere?

Let's keep it open. It should close automatically on deploy

@neil-marcellini
Copy link
Contributor

Hi there, when it comes time to do the Bug-Zero checklist, please note that the first 2 steps are done here #12629 (comment).

@melvin-bot melvin-bot bot added the Overdue label Nov 25, 2022
@Gonals
Copy link
Contributor Author

Gonals commented Nov 25, 2022

This should have closed on deploy 🤷

@Gonals Gonals closed this as completed Nov 25, 2022
@melvin-bot melvin-bot bot removed the Overdue label Nov 25, 2022
@parasharrajat
Copy link
Member

parasharrajat commented Dec 9, 2022

@lschurr Bump for payment of internal PR review.

@lschurr
Copy link
Contributor

lschurr commented Dec 9, 2022

Hm, this was closed so I wasn't aware we needed to issue any payment. @Gonals can you confirm what's needed here?

@lschurr lschurr reopened this Dec 9, 2022
@melvin-bot melvin-bot bot added the Overdue label Dec 12, 2022
@lschurr
Copy link
Contributor

lschurr commented Dec 13, 2022

@melvin-bot melvin-bot bot removed the Overdue label Dec 13, 2022
@lschurr
Copy link
Contributor

lschurr commented Dec 13, 2022

Thanks for your patience @parasharrajat - could you apply to the job in Upwork? https://www.upwork.com/jobs/~01217e56876e8229f2

@parasharrajat
Copy link
Member

@lschurr you will have to invite me to the job. It is invite only.

@lschurr
Copy link
Contributor

lschurr commented Dec 13, 2022

Hm I think I made it public.. can you try again @parasharrajat?

@lschurr
Copy link
Contributor

lschurr commented Dec 14, 2022

@parasharrajat - offer sent in Upwork!

@lschurr
Copy link
Contributor

lschurr commented Dec 14, 2022

@parasharrajat - just confirming that I sent that offer to the right contributor. Could you confirm you got it?

@parasharrajat
Copy link
Member

parasharrajat commented Dec 15, 2022

@lschurr yeah, you have sent it to the correct account. Accepted.

@lschurr
Copy link
Contributor

lschurr commented Dec 15, 2022

Great, paid!

@lschurr lschurr closed this as completed Dec 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants