[$250] Feature request - Show content when open deep link from other user profile which is not in contacts list reported by @aimane-chnaif

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Problem:

It shows loading forever. Especially, when someone shares user profile link from other social app and open it, user gets confused.

Solution:

The page should show content. i.e. no access page, 404 page, or show "not in contacts" message and create new chat button, etc. At least should show close button to exit this page and go back to home screen.

Context/Examples/Screenshots/Notes:

infinite.loading.mp4

Platform:
Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web
  Logs: https://stackoverflow.com/c/expensify/questions/4856
  Expensify/Expensify Issue URL:
  Issue reported by: @aimane-chnaif
  Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1666005837666169
  View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @lschurr (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[lschurr]

I'm not super clear on what kind of links cause this problem. Adding eng for a second pair of eyes.

[melvin-bot]

Triggered auto assignment to @alex-mechler (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[alex-mechler]

Are there any logs errors when this happens? Its possible that this is a bug and not a new feature

[aimane-chnaif]

@alex-mechler you can test with 2 accounts.
After login account A, open user profile with which doesn't have contact in account B.
Copy profile link and try to open it after login account B.

[alex-mechler]

Looks like there is no console errors from my limited testing. Seems useful that we would show / do anything other than an infinite loader here, but I'm not sure what yet. Doing some more digging / exploring before continuing

[alex-mechler]

Okay, after digging in more, properly loading the details for the user in this case would be quite a large amount of internal API work, so lets stick with showing an error growl and closing the modal.

Sending this external

[melvin-bot]

Triggered auto assignment to @ntrepanier (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Triggered auto assignment to @AndrewGable (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[ntrepanier]

Based on what @alex-mechler said above. I agree that this isn't really worth fixing at this point. As it's a feature request and not a bug, I'm going to go ahead and close it. Feel free to re-open if you disagree.

[aimane-chnaif]

I think this is duplicated with https://github.com/Expensify/Expensify/issues/238890 (internal) and now that PR merged and deployed to production.
So I think I am eligible for reporting bonus.
cc: @ntrepanier @alex-mechler
and @stitesExpensify (since you fixed issue)

[stitesExpensify]

@aimane-chnaif it actually looks like this issue is not fixed by that PR. The app actually breaks instead of an endless loading spinner if the user has no details whatsoever (including no email/login) 😅

[aimane-chnaif]

@stitesExpensify that crash is regression from recent PR.
Here's solution someone proposed already: #12487 (comment)

[aimane-chnaif]

As you're testing locally, just try this simple fix and test.
You can also confirm working on current production v1.2.23-9
This crash is reproducible on staging v1.2.24-0

[aimane-chnaif]

@stitesExpensify Now that PR is merged and deployed to production, the crash is gone in latest main. You can confirm on staging/production as well.

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Current assignee @eVoloshchak is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Current assignee @AndrewGable is eligible for the External assigner, not assigning anyone new.

[stitesExpensify]

Thank you for bringing this up @aimane-chnaif after re-looking at this, I agree that you should get the reporting bonus since this issue was created before the one that I fixed in my PR.

@michaelhaxhiu can you create an upwork so that we can hire and pay @aimane-chnaif the reporting fee, and then close this issue back out?

[michaelhaxhiu]

https://www.upwork.com/jobs/~01cd49405208836adb

invited you @aimane-chnaif. Let's pay and close today if possible :)

[aimane-chnaif]

@michaelhaxhiu accepted invitation. thanks

[michaelhaxhiu]

Hired, waiting on confirmation and then I'll pay it.

[michaelhaxhiu]

Paid and closing.