[HOLD for Regression Test] Web - Chat - After refreshing the page, the input field is initially missing

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to URL https://staging.new.expensify.com/
2. Login with any account
3. Go to any chat
4. Refresh the page

Expected Result:

The input field should be visible immediately

Actual Result:

The input field is initially missing

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.15.2

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2370.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~017e4db016aa092c59
• Upwork Job ID: 1606465371376586752
• Last Price Increase: 2022-12-24

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[parasharrajat]

Should be marked as regression. I would say deploy blocker. This is serious one.

[bondydaa]

it's reproducible on production already so that's why there's no deploy blocker

[bondydaa]

just looking at recent PRs these could be related

#11217
#10591

those both of those are pretty old.

[bondydaa]

cc @jasperhuangg

[bondydaa]

tossing this to the pool as I'm not the most qualified to handle this

[melvin-bot]

Whoops! This issue is 2 days overdue. Let's get this updated quick!

[parasharrajat]

@bondydaa let's re-apply the engineering label so that someone is assigned to it. Seems important to me.

[bondydaa]

that's not exactly how our system works. the person assigned to triage (me) can chose to keep assigned if they're going to work on it or send it to our engineering pool for it to be picked up. The engineering label isn't a "you must do this" it just annoys other engineers when they have to context switch, see it's been triaged, unassign themselves again. It's marked as a daily, which I think is the correct label as well.

[parasharrajat]

Ok, I see.

[melvin-bot]

Triggered auto assignment to @isabelastisser (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[isabelastisser]

Reviewing this now.

[isabelastisser]

I was able to reproduce it:

Missing.input.field.mp4

[melvin-bot]

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[0xmiros]

New PR is reviewed by @thesahindia.
So, while @Beamanator is OOO, I appreciate @marcaaron (reviewed previous PR) or any other engineer can take and review this PR.

[0xmiros]

@arosiclair thanks for quick review

[mallenexpensify]

For internal engineers and C+, the BugZero (BZ) team will need some guidance on payment here, specifically the 50% penalty for - "Merged PR within 9 business days - 50% penalty". @0xmiroslav feel free to provide details as well.

Nov 4th - new process with bonus for timeliness (link)
Nov 7th - @0xmiroslav hired
Dec 28th - PR merged.

[0xmiros]

I agree penalty would be applied from PR timeline but there's a lot of back and forth for enough reason.
Here's original slack conversation.
So I'd like to request re-evaluation because scope changed a lot than before assign.
cc: @Beamanator @rushatgabhane

[rushatgabhane]

Merged PR within 9 business days - 50% penalty

let's stick to the process. agree!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.46-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix composer hidden while loading messages #13523

If no regressions arise, payment will be issued on 2023-01-09. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@rushatgabhane / @thesahindia / @Beamanator] The PR that introduced the bug has been identified. Link to the PR:
• [@rushatgabhane / @thesahindia / @Beamanator] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@rushatgabhane / @thesahindia / @Beamanator] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mallenexpensify / @greg-schroeder] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/258910

[mallenexpensify]

I feel like this is kinda a "perfect storm" issue with so much happening between @0xmiroslav being hired and now (process change right before, the fix doesn't appear to be a quick one and required discussion, minimum job price soon after being hired, IP address issue in the middle, Christmas break). I'm leaning towards paying the full amount and calling this an edge case.

@0xmiroslav and @rushatgabhane can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~017e4db016aa092c59

[rushatgabhane]

@mallenexpensify wait. im not eligible for payment (I was OOO #13523 (comment))

@thesahindia reviewed the PR for this issue #13523 (comment)

[mallenexpensify]

Thanks @rushatgabhane, ended your contract. @thesahindia can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~017e4db016aa092c59

[thesahindia]

Accepted, thanks!

[mallenexpensify]

@thesahindia paid. @greg-schroeder or I need to add the regression test steps then we'll be done.

[greg-schroeder]

Working on regression test steps now (getting help from Sheena)

[greg-schroeder]

Regression check here: https://expensify.slack.com/archives/C01SKUP7QR0/p1675081857853569

[greg-schroeder]

File issue to update TestRail w/ new test: https://github.com/Expensify/Expensify/issues/258910

This issue is done now