Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VPRAB-3842: use newer graphql-tools dependency #99

Conversation

logovaser
Copy link

https://jira.expedia.biz/browse/VPRAB-3842

📝 Description

Resolves dependabot issue

@stigsell
Copy link

stigsell commented Aug 4, 2022

I have verified on my computer that this component can be built and works as expected in our polaris-api-federated-server project. I approve this PR.

@stigsell
Copy link

@tlivings could you please review this PR when you get a chance? We get dependabot alerts because of this dependency, so we would like to make the fix to prevent future alerts.

Thanks,
Nick Stigsell
PM Rates team - Escapia
[email protected]

Copy link
Collaborator

@tlivings tlivings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @brianjquinn can you take a look too and merge/release if good? On vacation and on a phone 😄

@HananeMoshe
Copy link

Thank you for jumping on this, I know you are on vacation Trevor. @brianjquinn when you get to this, is there any manual changelog that we need to update for this change? If so, let us know and we will take care of it. Thank you!

Copy link

@HananeMoshe HananeMoshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tlivings
Copy link
Collaborator

To release we need to bump minor version and then tag a release.

@HananeMoshe
Copy link

To release we need to bump minor version and then tag a release.

@logovaser @stigsell can one of you take care of this when you have some time. Thank you Trevor.

@logovaser
Copy link
Author

I don't have merging access

@tlivings tlivings merged commit 1f5233b into ExpediaGroup:master Aug 16, 2022
@logovaser logovaser deleted the VPRAB-3842_use_newer_graphql-tools_dependency branch August 17, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants