Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify time unit in the attribute name Alert->creationTime #102

Open
bibinss opened this issue Apr 4, 2019 · 0 comments
Open

specify time unit in the attribute name Alert->creationTime #102

bibinss opened this issue Apr 4, 2019 · 0 comments
Labels
enhancement New feature or request

Comments

@bibinss
Copy link
Contributor

bibinss commented Apr 4, 2019

attribute creationTime @ https://github.com/ExpediaDotCom/alert-manager/blob/master/api/src/main/java/com/expedia/alertmanager/model/Alert.java#L35
doesn't mention the unit though it expects it be in epoch seconds.
So a better name for this would be creationTimeInSeconds?

We need to notify our clients before we make this change.
@bibinss bibinss added the enhancement New feature or request label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bibinss