Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features for gzip, png, jpeg, ffmpeg #9

Open
ExpHP opened this issue Sep 10, 2018 · 0 comments
Open

Features for gzip, png, jpeg, ffmpeg #9

ExpHP opened this issue Sep 10, 2018 · 0 comments

Comments

@ExpHP
Copy link
Owner

ExpHP commented Sep 10, 2018

Features could be added to require these.

They should somehow use these C API functions to validate that the functionality is present in system libraries:

int lammps_config_has_gzip_support();
int lammps_config_has_png_support();
int lammps_config_has_jpeg_support();
int lammps_config_has_ffmpeg_support();

When activated in an automatic build, they should set the corresponding cmake flags to yes.

I don't think these features should be enabled by default, for the same reasons that exceptions is not on by default. However, unlike for mpi, I believe it is okay that cmake should be allowed to enable these libraries if they are found, even without the feature. (so without the feature, we should do nothing, rather than defining WITH_JPEG=no). This is because they do not require additional effort from us to link them, given that cmake could find them. (whereas linking MPI requires querying mpicxx)

...I think. I could be wrong.


I have no need for any of this myself, so I'll leave the effort to somebody who does. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant