Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: native restaking withdrawal checks could be bypassed #84

Closed
adu-web3 opened this issue Aug 30, 2024 · 0 comments · Fixed by #85
Closed

Bug: native restaking withdrawal checks could be bypassed #84

adu-web3 opened this issue Aug 30, 2024 · 0 comments · Fixed by #85

Comments

@adu-web3
Copy link
Collaborator

Description

It is intended that for Ethereum native restakers, they must call NativeRestakingController.processBeaconChainWithdrawal to verify beacon chain merkle proofs and withdraw from Exocore, while this intention could be bypassed by calling LSTRestakingController.withdrawPrincipalFromExocore to specify token parameter as VIRTUAL_STAKED_ETH_ADDRESS(0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeeeeeEEeE)

This is because we use the same Action for both withdrawal functions and from Exocore chain perspective, it can not tell whether the request was initiated from withdrawPrincipalFromExocore or processBeaconChainWithdrawal.

reference: https://skyharbor.certik.com/report/b766f0c2-165b-473a-86c6-cb33348df784?findingIndex=NRC-03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant