Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Layout CI does not work from forked repos #126

Closed
MaxMustermann2 opened this issue Nov 18, 2024 · 0 comments · Fixed by #127
Closed

[CI] Layout CI does not work from forked repos #126

MaxMustermann2 opened this issue Nov 18, 2024 · 0 comments · Fixed by #127
Assignees

Comments

@MaxMustermann2
Copy link
Collaborator

The proposed solution is to split the CI into 2.

  • The first works on the PR + base branch and is triggered by pull_request. It caches the layouts from the PR (and the base branch for ExocoreGateway)
  • The second works after the first one has been triggered using workflow_run and compares the cached layouts + calls to cast storage.
  • Instead of using our custom Python script, we should use the tooling provided by OpenZeppelin to compare these layouts.

I have implemented most of this but it needs to be tested. PR foundry-rs/foundry#9332 adds support for cast storage to export the JSON layouts. Now that it has been merged, I will wait for a nightly release that includes this change and test it out on my fork before sending the PR out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant