You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Though we only create vault for whitelisted tokens, it's better we specify in the comment that the whitelisted token should not be fee-on-transfer token. For fee-on-transfer token, if A transfers X amount of token to B, the transfer would burn part of token as fee Y, so the vault would receive less amount of token(X-Y) then expected when user deposits, so we should make this clear in code comments or doc.
The text was updated successfully, but these errors were encountered:
Description
Though we only create vault for whitelisted tokens, it's better we specify in the comment that the whitelisted token should not be fee-on-transfer token. For fee-on-transfer token, if A transfers X amount of token to B, the transfer would burn part of token as fee Y, so the vault would receive less amount of token(X-Y) then expected when user deposits, so we should make this clear in code comments or doc.
The text was updated successfully, but these errors were encountered: