Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LST][Security]: current vault does not work with fee-on-transfer tokens #1

Closed
adu-web3 opened this issue May 30, 2024 · 0 comments · Fixed by #69
Closed

[LST][Security]: current vault does not work with fee-on-transfer tokens #1

adu-web3 opened this issue May 30, 2024 · 0 comments · Fixed by #69

Comments

@adu-web3
Copy link
Collaborator

Description

Though we only create vault for whitelisted tokens, it's better we specify in the comment that the whitelisted token should not be fee-on-transfer token. For fee-on-transfer token, if A transfers X amount of token to B, the transfer would burn part of token as fee Y, so the vault would receive less amount of token(X-Y) then expected when user deposits, so we should make this clear in code comments or doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant