-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition to C++11 and CI jobs covering more cases #601
Conversation
- give names to jobs. - Use git settings. - Update Ubuntu version to xenial. - New travis jobs. - Simplify conan configuration. - create default conan profile. - gtest shared & libstdc++11 always - New OSX job. - Simplify Travis configuration. - simplify cmake options - Release and Debug builds
Note that the Fedora job in gitlab failed due to some network issue, but the rest of the jobs passed. |
I have restarted the Fedora job on Gitlab. |
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
==========================================
- Coverage 62.78% 62.61% -0.17%
==========================================
Files 154 154
Lines 20704 21094 +390
==========================================
+ Hits 12998 13209 +211
- Misses 7706 7885 +179
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work!
In this first PR we finally do the migration to C++11.
Basically this PR is a continuation of #257 which was not merged in April 2018 because we took the decision of not switching to C++11 on the Exiv2 0.27 version.
I could not apply directly the commits that @D4N wrote in that PR, however all the kudos related to that change should be forwarded to him 😉 .
This PR solve some of the items discussed in #214 but not all of them. After this PR is merged, we can continue implementing some of the items that @D4N carefully wrote in that issue.
These are the changes implemented in the PR:
auto_ptr
and replace it withunique_ptr
Release/Debug, X86/X64.
check_include_file
that were not needed. This speeds up considerably the CMake configuration step.Since the PR is quite large, I would recommend you to review it commit by commit. Each commit is focused in independent topics.
Note: I will squash some of the commits related with travis and appveyor. Right now there are many commits that I pushed while testing the proper execution of the CI jobs.