Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test all Canon lenses #1428

Closed
wants to merge 7 commits into from
Closed

Test all Canon lenses #1428

wants to merge 7 commits into from

Commits on Dec 9, 2020

  1. Fix rounding error in fnumber calculation 

    The mathematical calculation of fnumbers does not always match the expected
values: For example for f/3.5 the precise mathematical value is 3.564...,
which gets rounded to 3.6. Fix this special case by returning a value
closer to the expected value.
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    e0b2022 View commit details
    Browse the repository at this point in the history

  2. Fix misdetection of Tamron SP AF 300mm as Canon EF 75-300mm 

    When searching for the Tamron lens, only the string "300mm" is searched in
the lens description, which also happens to be present for the Canon lens.
Since the Canon lens comes first in the list, it wins. Fix this issue by
prefixing the search string with a single space so it always has to match
the full focal length specification.
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    b6d0001 View commit details
    Browse the repository at this point in the history

  3. Improve detection of Canon lenses with TC 

    Lenses with and without a TC may share the same lens ID. Prefer entries
that explicitly mention the TC.
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    f5e3712 View commit details
    Browse the repository at this point in the history

  4. Clean up Canon lens list 

    Fixes some small inconsistencies, so that all lenses use the same format,
that is also shared with other lens databases such as lensfun:
* Always prefix aperture with f/
* Never add .0 to aperture
* Always add mm to focal length
* Always use | A for Sigma Art lenses
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    6a49e47 View commit details
    Browse the repository at this point in the history

  5. Remove undetectable lenses 

    Lenses that have the exact same ID, focal length and aperture as some other
lens that comes earlier in the list (and thus always wins):
* 137, "Tamron SP 17-50mm f/2.8 XR Di II VC"
* 137, "Tamron SP 24-70mm f/2.8 Di VC USD"
* 161, "Sigma 28-70mm f/2.8 EX"
* 173, "Sigma 180mm EX HSM Macro f/3.5"
* 180, "Zeiss Milvus 50mm f/1.4"
* 183, "Sigma 150-600mm f/5-6.3 DG OS HSM | S"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F004"
* 254, "Tamron SP 90mm f/2.8 Di VC USD Macro 1:1 F017"

Lenses that share their IDs with other lenses, but have no or an
unsupported focal length:
* 33, "Voigtlander or Carl Zeiss Lens"
* 131, "Sigma 4.5mm f/2.8 EX DC HSM Circular Fisheye"
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    8465a9f View commit details
    Browse the repository at this point in the history

  6. Execute test commands always with shell 

    There is no need to handle tests on Windows and Unix differently here.
Always using a shell allows for more flexibility when writing tests.
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    aa4bbf1 View commit details
    Browse the repository at this point in the history

  7. Add test for all known Canon lenses 

    Generates a test case for every known lens from canonCsLensType, that first
sets the corresponding lens metadata and then verifies that exiv2 maps it
to the expected lens description. Only metadata fields that are relevant
for lens identification are modified.
    @webmeister
    webmeister committed Dec 9, 2020
    Configuration menu
    Copy the full SHA
    d3075af View commit details
    Browse the repository at this point in the history