Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code in main does not compile on F38 #2557

Closed
1div0 opened this issue Mar 21, 2023 · 3 comments · Fixed by #2558
Closed

Code in main does not compile on F38 #2557

1div0 opened this issue Mar 21, 2023 · 3 comments · Fixed by #2558
Labels

Comments

@1div0
Copy link
Collaborator

1div0 commented Mar 21, 2023

I dared to upgrade to Fedora Linux 38 β. However, Exiv2 code in main branch does not compile cleanly neither w/ GNU Compiler nor w/ LLVM based Clang++.

Please see the logs.
Exiv2 GCC 13 F38.log
Exiv2 LLVM 15.0.7 F38.log

On F37 it was OK.

[RFC] Anyone experienced the same issue?

@1div0 1div0 added the bug label Mar 21, 2023
@kmilos
Copy link
Collaborator

kmilos commented Mar 21, 2023

Probably need to include cstdint (or cinttypes if printf macros are needed as well) in types.hpp explicitly, most recent compilers got picky about it... Surprised our CI didn't pick this up already...

https://gcc.gnu.org/gcc-13/porting_to.html

Edit: Yep, our CI doesn't really test any more recent compiler than (outdated) Ubuntu GCC default, not good... (On Windows/MSYS2 LLVM 15 has been available for a while, but we don't test the CLANG64 environment, only UCRT64 which uses GCC 12 currently...)

@kmilos
Copy link
Collaborator

kmilos commented Mar 21, 2023

@1div0 Please test and feedback if this change is sufficient.

@1div0
Copy link
Collaborator Author

1div0 commented Mar 22, 2023

@kmilos hvala.

Yes, the change is sufficient to fix the compilation with GCC 13 as well as Clang 15.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants