Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buy and sell max possible quantity #1877

Open
michael1011 opened this issue Sep 8, 2020 · 4 comments · May be fixed by #1922
Open

buy and sell max possible quantity #1877

michael1011 opened this issue Sep 8, 2020 · 4 comments · May be fixed by #1922
Assignees
@rsercano
Labels
command line (CLI) Relating to the command line interface tools P3 low priority

Comments

@michael1011
Copy link
Contributor

The buy and sell commands should have an --all flag to issue an order with the max possible quantity to avoid having dust left over in channels
@michael1011 michael1011 added P2 mid priority command line (CLI) Relating to the command line interface tools labels Sep 8, 2020
@kilrau
Copy link
Contributor

kilrau commented Sep 8, 2020

👍 for the feature request but should we go for sell all ltc/btc 0.01 - replacing the quantity with all to avoid complicated cli args fiddling with an optional appended [-all] parameter? List above as example in the cli help, then is should be clear that this option exists and how to use it. We did that in other commands too recently.

@kilrau kilrau added P3 low priority and removed P2 mid priority labels Sep 8, 2020
@kilrau
Copy link
Contributor

kilrau commented Sep 8, 2020

Lowering to P3 though, since this is trading, not market maker functionality.

@rsercano
Copy link
Collaborator

Let me know if I may have a look at this :)

@kilrau
Copy link
Contributor

kilrau commented Sep 16, 2020

You got it, same here though: there are higher prio issues

@rsercano rsercano linked a pull request Sep 27, 2020 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rsercano rsercano

Labels
command line (CLI) Relating to the command line interface tools P3 low priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding new flag to trade all possible quantity for buy/sell ExchangeUnion/xud
3 participants
@rsercano @michael1011 @kilrau